The clone_access($node) function is not an implementation of hook_access($op, $node, $account).

The function should be renamed.

This affects drupal 5 & 6 versions.

CommentFileSizeAuthor
#6 805002-hook-access-D5x-1x-6.patch1.09 KBpwolanin
#3 805002-hook-access-D6-3.patch1.05 KBpwolanin
#2 805002-hook-access-D5-2.patch1.17 KBpwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

ugh, indeed - though this should only arise if you have a node type named 'clone', right?

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Active » Needs review
FileSize
805002-hook-access-D5-2.patch1.17 KB

Here's a Drupal 5 patch to test.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
805002-hook-access-D6-3.patch1.05 KB

Drupal 6 version - run update.php or force a menu rebuild

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented

By the way - CCK defines a function called content_access() - so be sure not to crate a custom node type named 'content'.

I assume you created a custom node type module?

rup3rt’s picture

rup3rt CreditAttribution: rup3rt commented

subscribe

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
805002-hook-access-D5x-1x-6.patch1.09 KB

5.x-1.x version

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Needs review » Fixed

committed patches

Agileware’s picture

Agileware CreditAttribution: Agileware commented

Thanks.

Actually I didn't have any problems with this but I had to do a custom clone form for a client that called some of your functions and I noticed it when I was looking through.

I don't think this is an uncommon issue among contrib modules.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.