Imagecache preset names are not user-firendly at all. Insert module's imagecache.inc exposes imagecache presets as strings for translation, see includes/imagecache.inc, line 17
'label' => t($preset['presetname']),

So colorbox.module, line 263
'label' => t('Colorbox: @preset image', array('@preset' => $preset['presetname'])),
could be replaced with
'label' => t('Colorbox: @preset image', array('@preset' => t($preset['presetname']))),

It already works for me without side effects.

CommentFileSizeAuthor
#2 colorbox-presetname-translation-3-810820.patch713 bytessoulfroys
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frjo’s picture

frjo CreditAttribution: frjo commented
Category: bug » feature
Status: Needs work » Closed (won't fix)

The label itself are already translatable. This is how the imagecache module does it.

soulfroys’s picture

soulfroys
Primary language Portuguese, Brazil
CreditAttribution: soulfroys commented
Priority: Normal » Critical
Status: Closed (won't fix) » Needs review
FileSize
colorbox-presetname-translation-3-810820.patch713 bytes

The label itself are already translatable. This is how the imagecache module does it.

Even though I'm translating the preset name, without the suggested change by @fasdalf@fasdalf.ru, does not work for Colorbox...

  • original presetname: post_big
  • translated: big
  • colorbox preset without patch (Colorbox: @preset image): Colorbox: post_big image
  • colorbox preset with patch (Colorbox: @preset image): Colorbox: big image

Please consider this feature... Thanks!

frjo’s picture

frjo CreditAttribution: frjo commented
Status: Needs review » Closed (won't fix)

Closing old issues that doesn't seems to effect a lot of users.

soulfroys’s picture

soulfroys
Primary language Portuguese, Brazil
CreditAttribution: soulfroys commented

I use this path in production. ASAP, I'll review this usability issue and post here.

Thanks!