Please view the attached screenshots. You can see the difference quite readily. In the first, the file attachments are not displayed in a table; they're just splatted on the screen. If you look at the firebug console, you can see there is no <table> element. In the second, the table is rendered properly.

These two sites are served by the same instance of Drupal.

I just updated the server to Ubuntu 10.04 (w/ php 5.3), although I don't know for sure when this started happening, so I don't know if they're related. The theme in use on the site with issues is Pixture Reloaded.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

binford2k’s picture

ping

binford2k’s picture

More information, I changed the theme to Garland and it did the same thing

binford2k’s picture

ping

binford2k’s picture

Version: 6.16 » 6.17
binford2k’s picture

ping

binford2k’s picture

PING

binford2k’s picture

Project: Drupal core » Private Upload
Version: 6.17 » 6.x-1.x-dev
Component: upload.module » User interface

Now that I have actually had time to look at it, I find that it's caused by Private Upload, not Drupal core at all.

kbk’s picture

Same problem here: Drupal 6.19, jQuery UI 1.7.3 (also tried 1.6), jQuery Update 1.3.2
Tried both Private Upload: 6.x-1.0-rc2 & 6.x-1.x-dev

Getting this error message:

warning: Parameter 1 to theme_private_upload_form() expected to be a reference, value given in /var/[mysite]/includes/theme.inc on line 656.

jrsinclair’s picture

I'm having the same issue. It appears to be related to using PHP 5.3 (this kind of error message usually is). Does anyone have any workarounds?

kbk’s picture

Probably not what you've got in mind but I've actually started using Private Download. Use CCK FileField to create a "Private" File Field and set the path to the private directory. Works well.

jrsinclair’s picture

Thanks @kbk, the more I read, the more it seems that private_download is the way to go. Private upload would be fantastic if it was a little more mature.

Firewolf’s picture

Same problem.
Subscribe.

Firewolf’s picture

FileSize
677 bytes

It seemed to be a php 5.2 vs php 5.3 issue. Attached a patch to solve the problem.

jp.stacey’s picture

The paths are wrong in that patch. The file private_upload_DEV_812194/private_upload.module doesn't exist, for example.

Otherwise I think it works fine. I've re-rolled it: can we get this patch committed? It's only a single character change.

jp.stacey’s picture

Status: Active » Needs review
Issue tags: +theme, +files, +attachments, +tabledrag

Setting to needs review, as I think the patch work is complete but it needs someone else to be able to apply it!

jp.stacey’s picture

Was getting a hunk offset - re-rolled (attached)

memcinto’s picture

Applied the patch in #16 and it fixed my problem. Hope this makes it into a new release of the module, along with http://drupal.org/node/1142534#comment-5491044!

mvc’s picture

Status: Needs review » Reviewed & tested by the community

#16 works for me, thanks!

kehogo’s picture

#16 works for me - thank you!

jszejner’s picture

Another verification that #16 patch fixes this issue and that it is caused by php 5.3 vs php 5.2

caw67’s picture

the patches are not in the new version!