HS Taxonomy loses selection upon node preview (patch copied from core)

Did a bit more debugging via devel, and on the nodes causing the issue there are some nulls in the array for the hierarchical select field, even though no nulls in the actual heirarchy. So it looks like an issue during saving?

Please if you can recommend compatible older versions, I'll try that out. The affected nodes can only be fixed manually though.

Critical for me, as nearly live...

Hope your exams go well. Thanks.

Ok, I tried various combinations of old versions of both modules but no solution.

Did some debugging in hierarchical_select\includes\theme.inc where the error message appears, and there are NULLs being passed to function _hierarchical_select_options($element)

So what is not clear to me as I am very new to this code, and please maybe you can explain to me:

- If the hierarchy is correct in the "view" mode, how does a heirarchy get transformed from "view" into the "edit" mode?

- what are the likely causes if view mode is fine, for the edit mode to be corrupt?

Please let me know, if you have the information in your head, so I can track down the bug.

Thanks for your help. Hope exams are fine so far.

The only other thing to mention is that I am using an implementation of hook_field_access() to hide or show the hierarchical_select fields depending on certain criteria during "edit" mode for a node.

My question is that, can you forsee any issue with this?

I did more debugging, and I think I have tracked down the issue.

When using hook_field_access() to hide a hierarchical_select field, for some reason, the 'tids' array contains NULLs, during preview. For instance, in an example I have:

using drupal_set_message( t( "field_xxx = " . var_export($node->field_xxx, TRUE)));

I get (when field is hidden, during preview ):

field_xxx = array ( 0 => array ( 'value' => NULL, ), 1 => array ( 'value' => '94', ), 2 => array ( 'value' => '91', ), 3 => array ( 'value' => '90', ), 'tids' => array ( 0 => array ( 'value' => NULL, ), 1 => array ( 'value' => NULL, ), ), )

instead of (when field is not hidden, during preview):

field_xxx = array ( 0 => array ( 'value' => '94', ), 1 => array ( 'value' => '91', ), 2 => array ( 'value' => '90', ), 'tids' => array ( 0 => array ( 'value' => '90', ), 1 => array ( 'value' => '91', ), 2 => array ( 'value' => '94', ), ), )

So it looks like hook_field_access has an impact.

Please I need your advice on the best way to resolve it, as I am not familiar with hierarchical_select code. Thanks for your help.

edit:
Decided to switch to a hook_form_alter() implementation as this seems more compatible with hierarchical_select. hook_field_access() implemetation does not work well hierarchical_select. Will keep you posted.

No patch, as what I eventually did was use a hook_form_alter() implementation as this seems more compatible with hierarchical_select. I also did a bit of defensive coding to ensure values set.

In general, it seems hs/ct potentially gives issue with data storage when a user previews before saving. Hence the issue when using hook_field_access().