If a Drupal site is called with permission for DFP but not to deliver an HTML page but some other file formats, then the result becomes invalid because of the appended DFP output. The attached patch avoids that. Note: This code is borrowed from the Devel project.

CommentFileSizeAuthor
dfp_support_xmlrpc.patch841 bytesjurgenhaas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frob’s picture

frob
Primary language English
CreditAttribution: frob commented
Category: bug » feature
Status: Active » Postponed (maintainer needs more info)

Thank you for submitting a patch. Unfortunately I have no real way of testing it. If you could please let me know if this is still an issue and maybe a bit more about how you are set up and using Drupal for Firebug.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
CreditAttribution: jurgenhaas commented

Thanks for getting back to this and yes, it is still an issue. What happens is that if using XMLRPC the calling (external) service expects to receive a response from the Drupal server which is formatted in XML which is normally no problem. If the response gets the DFP info appended, then the XML is broken and the external service most likely will break.

A good way for testing this is by using my module DRD which is a Drupal monitoring tool which grabs information from remote Drupal sites by using XMLRPC. If DrupalForFirebug is installed on the remote site then DRD won't be able to handle the responses.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented
Status: Postponed (maintainer needs more info) » Needs review

I will try and test this patch this weekend. I read it over and it looks good good, might even solve some other ajax issues.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented
Assigned: Unassigned » frob

assigning to myself.