I do not want to expose PHP to certain users who I do want to be able to use custom formatters.

I wrote a patch to add this new permission.
Please review and consider.

Also.
I had to add the function custom_formatters_advanced_form_access_denied because drupal_access_denied produces a "double-page" when access denied is returned.

I am unclear as to how to call drupal_access_denied function without rendering the page twice.
As a work-around I created the custom_formatters_advanced_form_access_denied function.

If a solution to using drupal_access_denied can be found please correct the patch or tell me how and I will correct the patch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Deciphered’s picture

Status: Needs review » Postponed

Hi thekevinday,

I really considered this, even began development, but unfortunately to do this the right way requires a lot more time than I am willing to give it at the moment as it would require permissions and checking for every single operation (clone, convert, edit, delete, etc).

I would suggest for the time being if this is definitely something you need in your project, use hook_form_alter() to remove/disable the advanced option from the creation form.

I will re-look at this in the future as it does make sense.

Cheers,
Deciphered.

thekevinday’s picture

Understood.

For that matter, I do not see the patch I was talking about.
I guess I forgot to submit it.

thekevinday’s picture

Status: Postponed » Needs review

The old patch does not need review because it no longer applies (it was against 6.x-1.4).

But I think at this point you now have enough changes in your module that this could be re-reviewed for addition?
I do not know what I need to do to update the patch to make it work with the latest code as it has been a long time since I even looked at this patch.

Deciphered’s picture

Issue summary: View changes
Status: Needs review » Closed (won't fix)

I am no longer supporting any Drupal 6 modules, as such I am marking this as closed.

However, I am open to taking on co-maintainers, if you wish to do so contact me via me D.o contact form.