Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This puts the preview where it's most needed and visible; to the right of the palette.
Coupled with #828578: Make clicks on theme settings preview select palette fields to edit would help out the UX of using color.module in Seven.
Attaching patch and screenshots comparing before-after while configuring Garland.
Comment | File | Size | Author |
---|---|---|---|
seven-proposed color preview placement.png | 64.25 KB | janusman | |
seven-current color preview placement.png | 101.32 KB | janusman | |
seven-better-color-preview-placement.patch | 2.46 KB | janusman | |
Issue fork drupal-831736
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #1
janusman CreditAttribution: janusman commentedForgot to mention this requires clearing caches as it overrides a default theming function.
Comment #2
aspilicious CreditAttribution: aspilicious commentedWill not work for small resolutions
Comment #3
janusman CreditAttribution: janusman commentedHmm, maybe I can add in some JS can add in a class to the #edit-color fieldset (that would enable the new CSS rules) only if it is more than a certain minimum width upon loading. Of course, then it would also need to handle resizing...
Comment #4
aspilicious CreditAttribution: aspilicious commentedYes and that will lead to unnecessary code. For me this is a won't fix.
Comment #5
slawira CreditAttribution: slawira commentedPatch no longer apply and also there are white space issues. I think we should use the media query for smaller resolutions @aspilicious.
Comment #6
LewisNyman CreditAttribution: LewisNyman commentedI don't mind this design improvement but it seems really complicated. We have layout classes in
system.admin.css
that you can use to achieve this without writing any CSS and JS.Comment #7
aspilicious CreditAttribution: aspilicious commented5 years ago I wasn't aware of that @slawira ;)
Comment #16
akashdab CreditAttribution: akashdab commentedPositioned color.module preview to suit larger screens better