datatype="" is output systematically in RDFa [#835906]

Due to recent changes in rdfui.module which might save an empty datatype, the RDFa markup might contain datatype="", resulting in HTML markup (like body field) to be treated as literal when, in RDFa 1.0 it would be parsed as rdf:XMLLiteral. We should be cautious and explicitly output the datatype so that there is no ambiguity between the different interpretation in RDF 1.0 vs. RDFa 1.1.

Comment	File	Size	Author
#7	835906-7-empty-datatype.patch	2.09 KB	linclark
#5	835906-5-empty-datatype.patch	1.95 KB	linclark

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Blooniverse CreditAttribution: Blooniverse commented 11 March 2011 at 17:36

... which datatype should this be, @scor?

Comment #2

scor CreditAttribution: scor commented 11 March 2011 at 20:56

there should be no datatype attribute at all in the RDFa output

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 7 April 2011 at 11:41

We should ensure that RDF UI module does not save the datatype (or delete the existing datatype) if the string is empty.

Comment #4

Anonymous (not verified) CreditAttribution: Anonymous commented 7 April 2011 at 11:41

Also, I would consider this an alpha blocker.

Comment #5

Anonymous (not verified) CreditAttribution: Anonymous commented 7 April 2011 at 12:52

Status:

Active

» Needs review

File	Size
835906-5-empty-datatype.patch	1.95 KB

Rewrote the logic to:

1. Load the original mapping
2. If there is field input for a key (i.e. predicates), then add that to the mapping or overwrite the existing value
3. If there is no field input, unset the value from the mapping
4. Save the mapping

This solves the datatype problem.

Comment #6

scor CreditAttribution: scor commented 8 April 2011 at 04:31

Priority:	Normal	» Major
Status:	Needs review	» Needs work

This patch solves the datatype issue.

3. If there is no field input, unset the value from the mapping

This is not enough, the whole mapping needs to be removed. If you blank the predicate in the mappings form and save, the field (e.g. body) will have property="" because the 'type' is still set to property by the form, which is fine, as long as the whole field mapping is unset during submit.

Comment #7

Anonymous (not verified) CreditAttribution: Anonymous commented 13 April 2011 at 11:57

Status:

Needs work

» Needs review

File	Size
835906-7-empty-datatype.patch	2.09 KB

Thanks for catching that, this one removes the entire mapping if the predicate is empty.

Comment #8

milesw CreditAttribution: milesw commented 13 April 2011 at 13:32

Tested #7 and it works as expected.

Before applying the patch I saved RDF mappings for the Article content type without specifying any datatypes. I found the RDFa for body was indeed outputting datatype="".

Applied #7, re-saved mappings for Article, and now there is no more empty datatype appearing. Nice work! :)