Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'm getting the following error when I try to close an Explorer modal dialog.
TypeError: Result of expression '$(widget).val(value).blur' [undefined] is not a function.
nodereference_explorer_plugin_content_nodereference.js
line 15, inside nodereference_explorer_plugin_content_nodereference_setValue()
function.
Gonna keep looking into this further.. I'm also trying to figure out why there is support for "Popups: Add & Reference", but the popups module is not available in the list of Modal Dialog APIs to use on the field edit page. Commented out? :/
Comment | File | Size | Author |
---|---|---|---|
#7 | explorer.dialog.css_.patch | 775 bytes | Ivo.Radulovski |
Comments
Comment #1
jwilson3More info... since I wanted to use Popups: Add & Reference module... so i updated jquery_ui to 1.7 (as required by the popups module).
Comment #2
gnindl CreditAttribution: gnindl commentedI could reproduce you error by
- Updating to the latest jQuery UI 1.7 http://code.google.com/p/jquery-ui/downloads/list?can=3&q=1.7
- Not using jquery_update or using jquery_update version 6.x-2.x-dev
Then you can open the dialog, but the tabs do not align and their URLs are messed up. Requires some work in explorer.tabs.js and nodereference_explorer.menu.inc
Further the theme looks a bit awkward.
It has no priority for me now, but if anyone can take this up it would be great. Shouldn't be too work intensive.
Comment #3
gnindl CreditAttribution: gnindl commentedchange title
Comment #4
gnindl CreditAttribution: gnindl commentedThis issue has partially been resolved. It works, but the theme still looks a bit messed up. Have a look at the latest release http://drupal.org/node/859402.
Comment #5
gnindl CreditAttribution: gnindl commentedAnother issue was posted #875984: What's going on with the theme? Expands on click?. The dialog increases its height when you click on it. This is probably caused by the JavaScript function Drupal.nodereference_explorer.dialog.resetDialogContentSize() in js/explorer.dialog.js. In jQuery UI 1.6 the dialog container has to be synchronized with the button pane which was solved in 1.7.
A solution which works in both version is desirable.
Comment #6
gnindl CreditAttribution: gnindl commentedAs expected it were the resize listeners needed as as hack for jQuery UI 1.6, so make it version dependent:
TODO: Still the theme looks a bit messed up and the scrollbars do not align.
Comment #7
Ivo.Radulovski CreditAttribution: Ivo.Radulovski commentedHere's a small fix for the dialog window, it should fix the scrollbar-alignment-problem and make the dialog-content-box appear flush with the title/bottom-bar.
Is there anything more specific that needs theming?
Comment #8
Ivo.Radulovski CreditAttribution: Ivo.Radulovski commentedOops, I just checked the attachment - will work on the styleguide ;)
What do you think of me co-maintaining the module?
Comment #9
stacysimpson CreditAttribution: stacysimpson commentedSubscribe
Comment #10
davidburnssubscribe
Comment #11
notasheep CreditAttribution: notasheep commentedsubscribe
Comment #12
tahiticlic CreditAttribution: tahiticlic commentedI've the same problem of modal frame height increasing on each click. When resizing the frame, the problem disappears and I can click "Ok" with a correct behavior.
This is with JQuery UI 1.7.3 and all correct stuffs.
The solution I've found is to comment this line (around line 40) in nodereference_explorer/js/explorer.dialog.js :
// focus: function() {Drupal.nodereference_explorer.dialog.resetDialogContentSize(this, options.height)},
I've not time enough to investigate why I've this behavior, I've done an update of Drupal core and before it was ok, so I guess there's now a conflict...
Comment #13
gnindl CreditAttribution: gnindl commentedPlease use Modalframe http://drupal.org/project/modalframe. It's stable to use with jQuery UI version 1.6 and 1.7. The in-built dialog API is deprectated in future releases and Modalframe will become a dependency of NRE.
To select modalframe as a dialog, go to your field settings and watch out for "Dialog API".