[PATCH] No tool selected by default in editing toolbar [#840336]

When editing a node with OpenLayersCCK widget the editing toolbar comes out at first with no tool selected,
but it really behaves as if the pan/move one (the hand) is selected.

Would seem a good idea to make this explicit by having the hand highlighted/selected by default.

I guess work is needed in the drawfeature JS

Comment	File	Size	Author
#2	DrawFeatures.defaultControl.patch	1.79 KB	strk
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

zzolo CreditAttribution: zzolo commented 29 June 2010 at 11:52

Category:

bug

» feature

Changing to feature request as I dont really consider this a bug. Thanks for catching this, though.

Comment #2

strk CreditAttribution: strk commented 29 June 2010 at 13:30

Category:

feature

» bug

File	Size
DrawFeatures.defaultControl.patch	1.79 KB

The attached patch implements the requested features.
I took the chance to also rewrite the nested loop used to decide which controls to allow, which sounded pretty convoluted to me.

PS: this was tested against a local copy of OpenLayers-2.9.1, which should be the same of the online API.

Comment #3

strk CreditAttribution: strk commented 29 June 2010 at 14:18

Title:	No tool selected by default in editing toolbar	» [PATCH] No tool selected by default in editing toolbar
Category:	bug	» feature

Sorry for changing back to bug report, was unintentional (altougth I would consider it a bug :P)

Comment #4

tmcw CreditAttribution: tmcw commented 29 June 2010 at 16:03

Looks good - not sure about the validHandler array though, it seems like the kind of thing that should be a function so that down the line we might use filter() to do this loop.