This is a great module. I have a problem with it on my node based user profile pages - which are presented in a panel.
On these pages there is a comment field acting as a guestbook. For some reason it is not picking up the node title - the comment subject appears pre-filled as just 'Re:' Submitted user profile comments all have the subject 'Re:' and the recent comments block looks pretty meaningless.
However, If I delete this 'Re:' in the subject line and add a comment and then submit it does then print Re: plus the correct node title along with the comment. So it seems it is almost working - but the initial presentation of the comment subject field is going wrong.
I've tried changing the module weight but this has no effect.
Any idea how to fix this?
Thanks for any info
Comment | File | Size | Author |
---|---|---|---|
#15 | 2011-02-04_847690_6x1x[unix].patch | 1.34 KB | arhak |
#1 | 2010-07-08_847690_5x[unix].patch | 560 bytes | arhak |
Comments
Comment #1
arhak CreditAttribution: arhak commentedthis is a quick shot in the dark
let me know the outcome
Comment #2
plan9 CreditAttribution: plan9 commentedHi
Thanks for the speedy patch! unfortunately It hasn't fixed the problem.
The comment form is inside a mini panel on a panels page. I don't know if this makes any difference?
Also: I am using Page Title with tokens to title profile pages with user names - but I did disable this and the comments subjects still behave as described.
Perhaps this should be in the panels queue?
Cheers
G
Comment #3
arhak CreditAttribution: arhak commentedI'm sure the problem is in this module
but I'm disinclined to set up a D5 with some 5.x modules
nevertheless, this problem might be present in 6.x version
how is the URL of those pages? (I mean without considering aliases, e.g. user/1/edit)
do you have Devel enabled? (having you to "Execute PHP" might help a lot, in a testing environment, of course)
Comment #4
plan9 CreditAttribution: plan9 commentedThe path to the page is user/%
I do have Devel on my development server - but only really know how to use it to clear caches.
I can do a minimal D5 install to test also.
Will report back.
G
Comment #5
arhak CreditAttribution: arhak commentedwhat I would like you to do is to enable the "Execute PHP" block (comes with devel)
place it in a sidebar (or footer, whatever region you want)
so I can provide some snippets to figure where the problem might be
Comment #6
plan9 CreditAttribution: plan9 commentedI've got the Devel block in the footer. If you go ahead and give me some snippets and instructions I will post the results.
Thanks.
Comment #7
arhak CreditAttribution: arhak commentedNote that I haven't examined D5 for API change,
so we might jump into incompatibility errors while trying to test these snippets (D6)
first, check that a proper comment_form is built
then, look for an existing node id to test how the subject is built
and finally, look for an existing comment id to test how the subject is built when replying to another comment
Note: for these test just pick up any $nid or $cid (of an existing node or comment respectively)
it doesn't matter if they're related, not even if comments are enabled
the form should be built on these arbitrary demands
Comment #8
plan9 CreditAttribution: plan9 commentedSuddenly - on my dev server - it started working properly (with patch applied in #1).
I disabled and re-eneabled the modules on the live site and it now appears to be working fine there also.
I have no caching whatsoever on the dev server - and I don't normally have to disable / re-enable modules when applying patches - who knows....
Anyway - basically your patch has made it possible for comment subjects to function inside panels pages. Perhaps this is also relevant for 6.x?
Thanks very much for all your help with this.
Comment #9
arhak CreditAttribution: arhak commentedyes, it is relevant for 6.x as well (is the same approach there, no consideration for comments out of node/* & comment/* paths)
however, I ask you to brake it again (in your dev server) to confirm that it is working thanks to the proposed patch
when you find the time, unpatch it (and if needed clear cache, re-enable it or what so ever, which BTW doesn't makes sense unless having some enabled cache getting in the middle)
and please, report back your results to make it official
thanks for your feedback
Comment #10
plan9 CreditAttribution: plan9 commentedHi
I have tested the unpatched version of the module and the bug re-appeared. So it looks like the patch is needed for comments in panels.
Thanks for fixing this.
Comment #11
arhak CreditAttribution: arhak commentedthanks
Comment #12
mitylite CreditAttribution: mitylite commentedCan somebody post the patched module for 6.2 dev? I'm not developer, I'm not able to apply patches...
Comment #13
arhak CreditAttribution: arhak commentedthe proposed fix would be applicable to 6.x-1.x, but not for 6.x-2.x
I don't think someone will post the whole module with a patch applied
if you're interested on making it work for 6.x-1.x you can copy the lines prefixed with a plus sign (see the patch) between lines 44 and 45 of the comment_subject.module file (version 6.x-1.x)
(or you may ask for a 6.x-1.x patch, but it seems that you won't know how to deal with it)
Comment #14
mitylite CreditAttribution: mitylite commentedNevermind my earlier comment I've learned about patching. :p
Comment #15
arhak CreditAttribution: arhak commented@#14 then for 6.x-1.x here you are
Comment #16
mitylite CreditAttribution: mitylite commentedThanks arhak. :p