Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
See the three screenshots. When you first add new content via the IPE — or move content from one region to another — a blank div appears to be inserted. This creates a false spacing until you reload the page.
Not a major blocker, but ideally after you hit "save" your page would be back to what it really looks like.
Comment | File | Size | Author |
---|---|---|---|
#32 | panels-n848704-32.patch | 1.3 KB | DamienMcKenna |
Comments
Comment #1
merlinofchaos CreditAttribution: merlinofchaos commentedHm. Pictures 4 and 5 seem to have invalid links, so I can only see 6.
Comment #2
joshk CreditAttribution: joshk commentedWhoops. Here they are again.
Comment #3
patrickroma CreditAttribution: patrickroma commentedActually I have a similar problem... After every panel region a
<div> </div>
is atuomatically inserted. Here is the code from firebug:I am searching everywhere to find the source of this div. Any ideas?
Using Panels 3.7
Thanx in advance
Comment #4
PetarB CreditAttribution: PetarB commentedI've got this issue too. Looks horrible. Any thoughts?
Comment #5
thowas CreditAttribution: thowas commentedEdit /sites/all/modules/panels/panels_ipe/js/panels_ipe.js
And remove " " from :
$('div.panels-ipe-sort-container', this).append('
');
Comment #6
Summit CreditAttribution: Summit commentedSubscribing, after hours of searching found this! Thanks, why is the empty line added?
greetings, Martijn
Comment #7
Wallack CreditAttribution: Wallack commentedDisable the panels inplace editor module.
This only appears if the user has the rights to use panel in-place editor but as many of you won't never use this module, disable it directly so it won't appear.
The blank space appears to be able to drag and drop blocks into regions when using inplace editor.
Regards!
Comment #8
bryancasler CreditAttribution: bryancasler commentedSame thing is happening in the 7.x dev. Like #7 said, just disable IPE to make it go away.
Comment #9
bryancasler CreditAttribution: bryancasler commentedForgot to update the version in my last post.
Comment #10
Summit CreditAttribution: Summit commentedWhy do you update the version please? It is still valid information for Drupal 6?
Whats the policy for changing version numbers?
greetings, Martijn
Comment #11
merlinofchaos CreditAttribution: merlinofchaos commentedAh hm. Yeah it's valid in both versions. I don't have a specific policy for versions, but let's leave this where it was.
This hasn't been fixed because I don't know how to fix it, btw. More or less, it's an artifact of the drag and drop system.
Comment #12
Summit CreditAttribution: Summit commentedHi Earl,
It is only there for login users with IPE permission. And if you know it, it's not a problem. Can't the blank line not get a meaning, something like "this line is there when you check IPE in Panels"?
greetings,
Martijn
Comment #13
tmsimont CreditAttribution: tmsimont commentedsame problem here.. #5 doesn't really work out.. :(
Comment #14
tmsimont CreditAttribution: tmsimont commentedi see this problem in 3.9
Comment #15
ccbearyeh CreditAttribution: ccbearyeh commentedThanks @Wallack, It's works for me. Just uninstall panels inplace editor module.
I'm using Panels 7.x-3.0-alpha3 and Drupal 7.10
Comment #16
ordermind CreditAttribution: ordermind commentedHere's the solution I came up with. It's sort of a quick fix but it works and should give you an idea of how to solve it in a better way. As I avoid hacking core and contrib this code goes in a separate js file. The basic idea is to hide the div dynamically whenever you're not actually using the ipe.
Comment #17
Nigel CunninghamI'm seeing this too, after enabling the IPE for my front page. I like the idea of adding and removing the nbsp as needed. Is that a possibility, Earl?
Regards,
Nigel
Comment #18
Nigel CunninghamHmm. How about modifying the line that adds the nbsp to:
$('div.panels-ipe-sort-container', this).append('<div class="panels-ipe-on" style="display:none"> </div>');
So that it's hidden when the IPE is not in use?
Comment #19
sdboyer CreditAttribution: sdboyer commentedThere are two problems being described in this issue. Everyone who's describing an empty div being generated who isn't using IPE (#3 and everyone responding to it), that's a separate issue; the original issue pertains to a case . A puzzling one, actually, as if you haven't explicitly chosen to use IPE to render a given Panel, there's no reason it would add anything to the page. And you do have to opt-in to using IPE.
...that having been said, the fix here was actually really simple. That empty div didn't need to be injected at all, there just needed to be a min-height set on the sortable container in order for it to still be a usable drop target. Much better solution, I've commushed the fix to 7. My local 6 instance is causing me some problems, though, so I'm marking this for backport.
Comment #20
patrickroma CreditAttribution: patrickroma commentedHow to fix this for D6?
Comment #21
merlinofchaos CreditAttribution: merlinofchaos commentedThe patch needs to be backported to D6. Unfortunately there is currently no one who has significant time to invest in D6 maintenance. Anyone still using D6 who would like to do the work to help update the patch would be most welcome.
Comment #22
patrickroma CreditAttribution: patrickroma commentedIf I could see the exact patch for D7 I would try...
Comment #23
merlinofchaos CreditAttribution: merlinofchaos commentedhttp://drupalcode.org/project/panels.git/commitdiff/0d3a102158498d1fa29b...
Comment #24
imatsu@drupal.org.es CreditAttribution: imatsu@drupal.org.es commentedEspañol:
Yo pude remover este div desde el archivo /sites/all/modules/panels/plugins/styles/default.inc
en la línea 23:
$output .= implode('<div class="panel-separator"></div>', $vars['panes']);
lo convertí en
$output .= implode('', $vars['panes']);
English:
In the file /sites/all/modules/panels/plugins/styles/default.inc remove
in line 23.
$output .= implode('<div class="panel-separator"></div>', $vars['panes']);
to
$output .= implode('', $vars['panes']);
Comment #25
FAAREIA CreditAttribution: FAAREIA commentedHi people, i'm always deleting
<div class="panel-separator"></div>
in every project i start. I like to have a clean layout and no extra css. It would be great if we do not include this unwanted/unnecessary tag anymore.Thanks for your time.
Comment #26
merlinofchaos CreditAttribution: merlinofchaos commentedStakcreativa:
As pere #19:
Returning to previous status. This issue is about a needed backport of a bugfix from Drupal 7 to Drupal 6.
Incidentally, if you want to get rid of the panel separator, just theme the region style to make it go away. Or just add a display: none for it in your CSS to ensure it doesn't display anything. In general, there's no need to get rid of it, and it's useful if you want to actually display something for the separator, such as a background gif.
Comment #27
merlinofchaos CreditAttribution: merlinofchaos commentedComment #28
merlinofchaos CreditAttribution: merlinofchaos commentedBTW the theme function you want to override to get rid of it completely and forever is
theme_panels_default_style_render_region
Comment #29
FAAREIA CreditAttribution: FAAREIA commentedThanks merlinofchaos, i really ever saw it was themeable. (-_-)
Sorry for my previous post.
Comment #31
DamienMcKennaComment #32
DamienMcKennaI manually recreated sdboyer's changes.
Comment #33
DamienMcKennaComment #34
japerryI had to do some re-formatting before committing, but it fixes the problem for me. Committed.