Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Was adding an argument, and saw the following string (in the taxonomy argument plugin):
"Load default argument from node page, thats good for related taxonomy blocks."
Attaching a one-line patch that fixes this.
Might be even nicer to say "Load default argument from node page. Good for related taxonomy blocks.", but that's for you to decide.
The issue is silly, but hey, a little polish never hurt anyone ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | alternative.patch | 561 bytes | bojanz |
| fix.patch | 568 bytes | bojanz | |
Comments
Comment #1
bojanz CreditAttribution: bojanz commentedAttaching the alternative patch too (the second suggested string).
Comment #2
dawehnerLooks fine.
This patch should be first commited to 2.x and 3.x
Comment #3
bojanz CreditAttribution: bojanz commentedWhich one, the first or the second one?
I can roll it for other branches...
Comment #4
dawehnerAh. I just read the second one. I'm not an expert in english grammar, but the second looked nice for me.
Comment #5
bojanz CreditAttribution: bojanz commentedJust tested, the patch (alternative.patch) also applies to the DRUPAL--6-3 and DRUPAL--6-2 branches.
Awesome!
Comment #6
dawehner.
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedPlease try to roll patches from the 'views' root directory, it's much easier to apply them that way.
Please don't change the quoting. ' is the preferred quoting to use on t() unless there is a ' in the sentence.
OTHER than that. Committed to all branches.