Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This merges the 'clock_timezone_type' and 'clock_custom_timezone' variables, since the values are exclusive to each other.
It makes the surrounding a little (!) heavier, but I think it is cleaner that way. Also comes with a little code clean-up, for instance the help text for D7 was still referencing D6 paths, and the SimpleTests had all the t()'s.
Haven't written upgrade path yet (For D6).
Note that this doesn't pass the tests yet, will have to clean it up before committing.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | update_return.patch | 620 bytes | tstoeckler |
| #2 | states.patch | 354 bytes | tstoeckler |
| #1 | code-overhaul.patch | 30.02 KB | tstoeckler |
| clean_up.patch | 26.1 KB | tstoeckler |
Comments
Comment #1
tstoecklerCommitted the attached patch.
Everything works fine, now.
Except for the states.js. Will look into that now.
http://drupal.org/cvs?commit=398560
http://drupal.org/cvs?commit=398432
Comment #2
tstoecklerQuick follow-up patch. Only applies for HEAD (this was fixed already in 7-1.x for whatever reason).
http://drupal.org/cvs?commit=398570
Marking fixed. Please reopen if you encounter problems.
Comment #3
tstoecklerAhh, forgot to fix one small little detail before committing. The update function doesn't give you a nice return message.
Here we go.
http://drupal.org/cvs?commit=398578
http://drupal.org/cvs?commit=398580
Comment #5
tstoecklerLeftover t()'s in clock.test.
http://drupal.org/cvs?commit=433090