Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Ower Barton discovered an interesting bug when ctools is used to provided exportables for wysiwyg:
See: #624018-81: Exportables and Features support for WYSIWYG 7.x
As far as I can tell it is not joining to the exportables table at all, and hence is not picking up the machine name for the input format, causing the array items to have no key and them clobbering each other.
I did some research, and the problems seems to be related to a check in ctools_export_get_schema() to ensure that that schema contains an 'export' array inside.
Well, this is required for based tables, due exportables uses that info to create exportables, but this is not so true for joined tables. After all, joined tables are used as a complement of the base table.
The attached patch allows to skip this check if the table is used as a join of another one.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | ctools-862320.patch | 874 bytes | dagmar |
| ctools_get_schema_as_join.patch | 1.39 KB | dagmar |
Comments
Comment #1
dagmarPlease do not commit this yet. It does work well with features.
Comment #2
dagmarOk, here is:
We use drupal_get_schema() instead of ctools_export_get_schema() to return a schema even if 'export' is not present on the joinned schema.
Comment #3
merlinofchaos CreditAttribution: merlinofchaos commentedAnd committed.