I found a need to do this and thought it might be handy to add

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

realityloop’s picture

Status: Active » Needs review
FileSize
1.79 KB

Patch attached

deekayen’s picture

Status: Needs review » Needs work

First, don't abbreviate variables with this module or any other. I thought at first you were checking to see if the site was defaulting to English before deciding whether or not to display a search box.

Since there are only two options, I'd think you could use 0 or 1. The variable itself isn't re-purposed anywhere else, so make it describe what it does, "masquerade_block_search_visibility".

I personally think radio buttons would be better here. Do you have some plans for other options in this box or a reason to need to select more than one?

You tried to stab a kitten with your patch by changing an unrelated string, which would affect translations which have already been submitted. That's a separate issue so the translation maintainers can be notified.

realityloop’s picture

Status: Needs work » Needs review
FileSize
1.39 KB

Thanks for the feedback, revised patch attached.

realityloop’s picture

FileSize
2.16 KB

Last patch didn't include uninstall for added variable, please test this one instead.

apaderno’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)

I am closing this feature request, as Drupal 6 is no longer supported. Please re-open it if you would like the feature implemented in the Drupal 7 or 8 version of the module.