Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Because http://drupal.org/node/421304 is applied, the interface for userpoints_nc became actually quite ugly and pretty unusable.
Attached patch solves this by displaying the settings of point for node insertion as a table.
Comment | File | Size | Author |
---|---|---|---|
userpoints_nc_theme.patch | 1.42 KB | Rolf van de Krol | |
Comments
Comment #1
gilgabar CreditAttribution: gilgabar commentedThank you. This is a much better way to present the point fields. All point assignment fields should be in tabular format.
Comment #2
Rolf van de Krol CreditAttribution: Rolf van de Krol commentedThis issue is RTBTC for quite a long time. Can module maintainer please take a look at it?
Comment #3
BerdirWell, the thing is that the 6.x version isn't really maintained ;)
I ported the module to 7.x (ported actually means that the module has been pretty much rewritten and redesigned in this case) and I moved the node type specific settings to the node type form and only left the default settings in the userpoints settings form.
I'm not saying that you need to do this, it doesn't make sense for a single setting, the 7.x version actually has a few settings which are content type specific. But I also don't have time to really maintain the 6.x version, apart from commiting a few RTBC patches maybe.
Anyway, I can give you a code review...
This needs the standard "Implementation of hook_theme()." doc comment. If you prefer, you can also use the D7 style: "Implements hook_theme()."
Same here, a short docblock which explains the theme function would be good.
You can use $op 'names' to only receive an array of the names, see http://api.drupal.org/api/drupal/modules--node--node.module/function/nod...
You could save the additional line if you assign the array directly to $rows[]. Doesn't really matter though, if you prefer it like this, leave it.
Maybe use Content type instead of just Type to make it clearer?
Missing space after comma.
Powered by Dreditor.