Hi Michelle,
I took some time away to give the module a chance to progress some more before testing it again. I've finally got my system up to date with the current services module, and still on the 6.x-1 branch of jquery update.. (not sure if they will play a role in why I'm still having issues with it or not).

I am using a non-artisteer theme this time, called LiteJazz, and also with Twilight. Let me ask this question just for the heck of it..

Am I supposed to actually see a section that shows the previous topic and then next topic above the area where it shows Tag: (to go to the list of topics in the forum)? or is the Navigation set to just take you to the list of topics themselves again?

I just cannot figure out what it is in my setup causing me such a hard time for the navigation links to show up. The box is checked for it to be turned on. Everything else about the module seems to be working as it should.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Michelle’s picture

No, it's not with the tags. It's at the bottom of the page.

Michelle

greywolfsspirit’s picture

FileSize
201.19 KB
245.79 KB
286.37 KB

well.. bottom of the forum page I see Top: # views, Reply, Delete, and Edit

Tag: (Forum Name)

then bottom of the screen, just my copyright notice, then my chatbar. So, it's still not wanting to co-exist with something on my site it seems.. :-(

Just now, it's not just an artisteer theme issue.

This is what I see (see attached images)
Jim

Michelle’s picture

Title: Revisiting the Navigation area » Topic navigation does not show on topic with no comments and no comment form
Category: support » bug

Aha! I finally figured it out. I guess I never tested the case where the site is using core comments and the comment form is on a separate page and the topic has no comments. That combination makes the comment section, where the topic navigation is located, not show up. Not sure what to do about it at this point, though. This is probably going to be an open bug for a while unless someone else wants to dive in since this is a bit of an edge case and there's a lot more pressing issues.

Michelle

greywolfsspirit’s picture

Category: bug » support

Great! So that means that all this time I wasn't going crazy for nothing then :-) So, it sounds like you know roughly whats causing it, and now it will be a matter of coming up with the solution. At least now we probably will put the Artisteer issue to bed along with this once the fix is done. (knock on wood). I'll keep an eye out here and if there is a patch made, I will try it on my site, and definately try it with standard and artisteer created themes as well and keep you informed in return if we have finally figured out this pesky, irritating, splinter under thumbnail thing lol. Thanks again, Michelle. Sorry for all the back and forth we've gone through exploring work arounds for what amounts to the completely wrong areas were were trying.

Jim

Michelle’s picture

Category: support » bug

Putting this back to bug report. It may not be a commonly used combination, since most people use the comment form as a "quick reply," but it is one that should work and needs to be fixed before release.

Michelle

greywolfsspirit’s picture

Something else I noticed that you can see on those images, Michelle.. while the images for the buttons show up, they are a little misaligned..(post reply and Reply) that would be in the css sheets for the advanced forum styles I'm sure.. I know you mentioned you needed to look at the stylesheets for the branch anyhow, so figured I would point this out since I had the pictures here already for you to see it in action.

Jim

jeckman’s picture

This happens for me using node comments, whether the comment form is in the same page or on a separate page - either way I'm not seeing the topic navigation on any forum topic with 0 replies

jeckman’s picture

Nevermind - they are there, just under the comment form - I thought they would be above the comment form.

I do not, however, get topic navigation using node-comments when there are no comments AND the comment form is on a separate page

jeckman’s picture

I thought I could just pull the <?php print $topic_navigation ?> out of the advanced_forum.naked.comment-wrapper.tpl.php and add to the advanced_forum.naked.post.tpl but it doesn't seem to work there.

Is the topic navigation somehow dependent on the comments?

I'd like to move it to the very topic of the topic, if possible

jeckman’s picture

Answering my own question, I found this in Advanced Forum's theme.inc, in the advanced_forum_preprocess_comment_wrapper function:

    // Grab the topic navigation that we hijacked in nodeapi.
    $variables['topic_navigation'] =  $variables['node']->advanced_forum_navigation;

So I copied this into the advanced_forum_preprocess_node function in the same theme.inc

and voila, now <?php print $topic_navigation ?> works in the advanced_forum.naked.post.tpl.php

greywolfsspirit’s picture

Out of curiosity, where in the function did you place this line? Can you post that section using the < code > and < /code > markers so we can take a look at it and see if we can duplicate your results? I've tried and it's not working for me so I want to see if I have placed it in the same spot. Thanks.

Jim

EDIT: Woohoo.. Michelle, I can confirm that this does fix the problem 99%. only thing I found is that if a topic name includes an apostrophe, it's throwing it up with html code instead (ie: Junior's Famous No.1 Cheesecake With 5 Variations (aka NEW York Cheesecake) Next topic: Ci Ci's Cherry Pizza › ) But, it is at least a very good sign for fixing the issue.

here's what I did based on Jeckman's suggestion:

in theme.inc, changed:

function advanced_forum_preprocess_node(&$variables) {
// Added lines below
     // Grab the topic navigation that we hijacked in nodeapi.   
    $variables['topic_navigation'] =  $variables['node']->advanced_forum_navigation;
// to here
 if (advanced_forum_is_styled($variables['node'], 'node')) {
 include_once drupal_get_path('module', 'advanced_forum') . '/includes/advanced_forum_preprocess_node.inc';
   _advanced_forum_preprocess_node($variables);
 }
}

then in advanced_forum.naked.post.tpl.php

<?php 
// Print the taxonomy terms for this node. This will print all terms,
// including the term of the forum itself. If you don't use any other 
// taxonomy on forum posts, you can safely delete this section.
?>
<?php if ($top_post): ?>
  <div class="forum-top-post-footer">
   <?php print t('Tags') ?>: <?php print $terms ?>:  <?php print $topic_navigation ?>            <--- added the print $topic_navigation here
  </div>
<?php endif; ?>

Now, all we need is to fix the issue of it throwing the ' instead of an apostrophe. I'm sure this is a simple fix. But, we have a working solution.

Greywolf

Michelle’s picture

#869006: Topic navigation run through check_plain twice it the apostrophe issue.

As for this, it's great that it'll work for you but I still need to figure out a solution that I can put in AF.

Michelle

greywolfsspirit’s picture

ahh okay so this was the issue on the check_plain twice.. okay.. didnt understand that a the time..

the fix should work for everyone, Michelle. You're not really changing much of anything, other than adding the print string in the one area, and adding variable declaration in the themes.inc file. I don't see where this would cause that big of an issue for others.. The work around is all AF files, not core files. But, (smiling) ya know the code better than I do.

-Jim

Michelle’s picture

Well, this work around puts the topic navigation back in the node which is where it is in core and undoes the AF feature that puts it at the end of the topic. If I was gonna do that, I'd just take out the feature rather than doing and undoing it. :)

Michelle

greywolfsspirit’s picture

Hmm.. That's odd that if you have it written to do it in the code to do this automatically, that doing this for our situations is what is required to get it to work. (scratching my head).. Maybe we need an argument tossed in the code that checks for cases where the AF is set up as we apparently have done, then it forces the call to the function to print the navigation line?
Perhaps something like a :

If (no comments) && (comment form is on a separate page) {
do topic_navigation
}

I know I'm over simplifying the function here, it's just an idea of something that might work?

This way, it would keep things working as you planned, and for those set up with comment form on separate page and no comments, this would allow your routine to do as it is supposed to do? I'm sorry if this sounds vague, but as i have no clue on how or where to even begin coding this, it's just an attempt at giving you a starting thought of where it might work.

Dont shoot me, I'm at least trying to offer suggestions. :-)

EDIT: Just did a quick look.. Michelle, are you passing the topic navigation through the check_plain function at all? I just looked in the files, and didn't see a call to it offhand. This issue just seems a little odd to me because the topic list displays the topic title just fine, however the topic navigation is apparently running through this filter for some reason. Will look at all the files in the morning and see if i can't track this down a little more. It just seems strange that if it works fine in one spot, logic dictates that it should be working correctly in the other. I'll dig out the bigger hammer in the morning and someone can bring the x-ray machine and we'll track this sucker down eventually.

Michelle’s picture

I don't know... As I said in that issue, I haven't had time to dig into it. I just noted it when I saw the problem on my site and that's all the farther it's gotten. I haven't had time to work on my modules lately.

Michelle

greywolfsspirit’s picture

Ok.. Well, I will take a stab at the code in the morning when I'm fresh and fully awake. At least you've been good about commenting your code up so I can follow the overall dynamics of it. I may not know exactly how to fix a problem, but I'll give you the results of what I find and let you (or merlin or whomever can code it). Bear with me if I come up with a lot of wild guesses, but hopefully (crossing fingers) we'll figure out the right fix.

Michelle’s picture

Well, basically I just need to see when there's no comments and no comment form and find the bottom-most place to put it in that case. In all other cases, it's already working. I just need to add in that exception.

Michelle

greywolfsspirit’s picture

Okay, so would you rather me just hold off then since you have more of an idea of what it needs then? I can live with this as is for now, so it's not that big of a rush for it to be handled. As long as I can at least get it working as it is now, that's what matters right now.

Michelle’s picture

@greywolfsspirit: Well, the problem is that I'm not getting much computer time. It's probably hard to tell since I'm pretty active in the queue but I'm often here for 5 minutes at a time and my queue is the first thing I check. So, while this probably isn't complex to fix, it may still be a while because I don't get all set up to work on the modules unless I have a good chunk of time to dedicate to it. So it may be a while before there's an "official" fix.

Michelle

greywolfsspirit’s picture

That's completely understandable. Like I said, I can live with it as-is for now. It'll get fixed when it gets fixed. I'm just glad that jeckman came up with a workaround that at least gives the function back to me for now. I did notice he's running with the Alpha version, where I am running the dev. copy, but the workaround does work in both. I just want to say that I do not mean to harp or come across in a bad light with my suggestions, or to make you feel pressured to address them right then and there. I never want anyone to feel that way. I am getting better at looking at the code, and have been assisting Travis with the dashplayer module, in terms of configuration problems that were happening with the update of services 6.x-2. But between he and I we finally ironed out the bugs there. So, maybe in time, I will be a better asset to the community in terms of understanding how all this code works, and can start getting my feet wet and work on some modules I would like to see. :-) One of the top ideas I want to work on is a module to allow an administrator to select what pages show which regions of a theme. For example.. the ability to turn off the header block on all pages except say the front page. Would be great for those using a media player or an arcade section, where it would just bring up the page with no other blocks, just the content and the navigation bar. There might even be a module out there that does this already, I haven't really looked around for one yet. Anyhow, thanks again for all the work and time you have put into all the modules you are working on.

Jim

Michelle’s picture

@greywolfsspirit: No worries. Me feeling pressured has more to do with the guilt of leaving so many people hanging while I juggle more projects than I can handle and my tendency to jump to whereever the latest fire is and try to fix that.

Michelle

Michelle’s picture

Heh... I didn't realize it but all this fuss is for a feature that's taken out of D7: #556136: Remove theme_forum_topic_navigation()

I knew it was a bad performing query, which is why I made it optional in AF. Guess they never figured out how to fix it. I'm not even sure why I have it enabled on my site, to be honest. I think I'm gonna go turn it off... I'll keep it in D6 but it's probably going to be gone in AF for D7 as well.

Michelle

greywolfsspirit’s picture

Hmm.. interesting how so many disliked the feature, but I can understand if removing it speeds things up too.. I might look into that post from
jmpoure - August 26, 2009 - 16:55

Why not integrate the source code of this module into core:

http://drupal.org/project/prev_next

The code is available.
Why not use it.

Michelle’s picture

Adding a contrib module to core is not a simple process. I guess no one has championed it.

Michelle

greywolfsspirit’s picture

guess not.. oh well.. I'll have to look over that prev_next mod later and see how it gets implemented in and see how much manipulation needs to be done to get AF to interact with it. Wont get a chance to do it til probably tuesday, though.

Michelle’s picture

Tagging

Michelle’s picture

Untagging... this isn't critical and is going to need to wait until after alpha 4, sorry.

jsibley’s picture

Another use case is using Disqus for comments and turning off Drupal comments. Ideally, there would be a place to display "previous" and "next" navigation somewhere on those pages.

It might also be worth looking into finding a way to work with custom_pager, which seems to have more users than prev_next. I can display it now, but it isn't particularly pretty. I'm also trying to figure out how to get the order right in what it considers to be previous and next, but that may just be because I'm new to it.

In any case, it might be less work to use what is already available than building something new for moving through forum topics.

Michelle’s picture

I'm not building anything new; I just moved what is provided by core into a more sensible location. The problem is that location relies on the comment wrapper. So I need to rethink and provide a proper footer outside of that instead. This functionality doesn't even exist at all anymore in Drupal 7 so I don't consider it critical but would like it to at least be consistent and not dependent on your comment settings.

Michelle

greywolfsspirit’s picture

I found that if you can't get the prev/next to work in AF, use the prev/next module, then set it to be used in AF. This has fixed my situation.

DamienMcKenna’s picture

Just to mention, with Michelle being busy for a little while (see note on the project page), someone else stepping up to help build a patch for this would be really beneficial to the project.

Michelle’s picture

I didn't have this one as a blocker because it only comes into play if you have the feature turned on which was removed from D7 core for being slow and fairly useless. :) That said, if someone wants to write a patch for it, I'll get it in. Otherwise this will be fixed as part of another issue (which I think may be only in my head at this point, not the queue, sorry...) to make a proper footer instead of relying on the comment wrapper.

Michelle

Michelle’s picture

Status: Active » Closed (won't fix)

It's been nearly a year and no one has stepped up to write a patch. If someone wants to, feel free to re-open. Otherwise this isn't going to get fixed in D6 and isn't an issue in D7.

Ingumsky’s picture

Status: Closed (won't fix) » Active

I re-open this issue. I'll try to dive into it and possibly will make a patch for it.

What do you think about printing comment_wrapper even if there's no built-in comments at all Michelle? It will most possibly solve two issues at once. One of them is navigation block disappearing from the page with neither comments nor comment form on it. The second one is an issue with broken layout for the first comment in a thread posted with Ajax Comments module (it works just perfect if there's at least one "properly styled" comment). Both of them are dependant on comment wrapper IMO.