Copy attributes on renewal by redefining "Set recurring fee same as product price" to mean "Repurchase product" [#878058]

I needed to be able to access the attributes of the original product when a renewal is processed. This allows for store administrators to view any attributes via email (using Conditional Actions) or the order interface without have to go back to the original order. Please review patch.

Comment	File	Size	Author
	uc_recurring-attributes.patch	1.38 KB	jdwfly

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

univate CreditAttribution: univate commented 10 August 2010 at 00:43

Status:

Needs review

» Needs work

This is what was being proposed in the issue: #857392: Redefine "Set recurring fee same as product price" to mean "Repurchase product"

I think we should only carry through all the product specific details if its actually repurchasing the same product and its not just a fee. So I can't accept this patch as is.

Comment #2

jdwfly CreditAttribution: jdwfly commented 10 August 2010 at 15:37

What about for recurring fees that have a specific breakdown for the fee that can be different each time the user purchases it? I am using this module for a church to allow for online giving where they can give to different parts of the ministry. On the back end the person running the store needs to know more than the total of what they gave, but also how much the person designated to each part of the ministry. As it stands right now they would have to go back to the original order to figure out those designations.

You can see http://www.lancasterbaptist.org/online-giving for my current setup. I am also using uc_varprice and then just simple text attributes for the amounts.

Also I looked for a similar issue but I missed that one. Anyway, what do I need to change so that you would accept this?

Comment #3

univate CreditAttribution: univate commented 11 August 2010 at 05:13

At the moment we have the option that says, make the recurring fee the same as the purchase price.

What the really means is that any attribute(s) that change the price we then carry that through that new price on the recurring payments. So we just need to take that option a little further so that the product added to the order on recurring is exactly the same as on the original purchase - this should theoretically mean that information like shipping is carried through as well as the details of the attributes. Hopefully if you made that change it would cater to your requirements.

Comment #4

univate CreditAttribution: univate commented 11 August 2010 at 06:19

Although I don't think we should copy the information from the original order, but instead store the details in the 'data' field and then use that to add to each recurring order, that allows us to change this information without effecting the original order.

Comment #5

univate CreditAttribution: univate commented 10 September 2010 at 07:54

Title:

Add attributes from old order to new order during renewal

» Copy attributes on renewal by redefining "Set recurring fee same as product price" to mean "Repurchase product"

Just marking the issue #857392: Redefine "Set recurring fee same as product price" to mean "Repurchase product" a duplicate of this one.

Comment #6

univate CreditAttribution: univate commented 22 October 2010 at 17:49

Priority:

Normal

» Major

I want to sort out this issue before next release.

Comment #7

ju.ri CreditAttribution: ju.ri commented 28 October 2010 at 18:53

Maybe this would also help with correct tax handling in renewed orders? see http://drupal.org/node/770604

Comment #8

petergus CreditAttribution: petergus commented 23 December 2010 at 02:55

has this been sorted out? i need exactly like you say univate, #3 perfect! is that in the latest dev?
thanks!

Comment #9

petergus CreditAttribution: petergus commented 5 January 2011 at 00:31

i just wana bump this up, and check, what is the status on getting the shipping (and attributes) carried through on each recurring order?

is it something to expect soon? in the meantime it seems i have to manually enter the shipping in each order as it processed, but what is the triggers for this?

this could be totally unrelated but...
im using the mock gateway and it just gets stuck on pending, is that a normal feature also when its live? each order must be processed manually, or is this a feature found elsewhere?

still trying to figure out just how extensible this module is, wonderfull as it is :)

Comment #10

EvanDonovan CreditAttribution: EvanDonovan commented 10 February 2011 at 03:40

If you are not selling shippable products, but simply access to a website (for premium content), is this issue irrelevant?

Comment #11

univate CreditAttribution: univate commented 10 February 2011 at 03:46

The recurring product fees was originally developed to just charge some amount on a recurring basis. This issue is about trying to actually linking these renewals into real product, so things like shipping and stock management just work as they do for normal orders. For use cases likes site subscriptions where you don't really care about stock control or shipping real products this issue doesn't really have any relevance.

If anyone is wanting to sponsor development on this issues, let me know. I want to get this feature in but without any clients currently requiring it its not that high on my list.