Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I'm not sure if this is intended or not but if it is I can always override the template in my subtheme;
I have a multiple value field using inline labels via panels (so far I'm only assuming this happens regardless of using panels).
This results in a label being printed for each value of the multiple value field, which seems a little odd.
For example, I have a country field displaying as:
Country: China Country: Indonesia Country: Australia etc.
Attached is a basic, possible fix.
| Comment | File | Size | Author |
|---|---|---|---|
| adaptivetheme-inline_labels.patch | 1.19 KB | Agileware |
Comments
Comment #1
Jeff Burnz CreditAttribution: Jeff Burnz commentedPatch is a good fix for a bad oversight... cheers very much.
Looking at this template again I'm wondering why I have inline items wrapped in DIV's and should perhaps change these to SPAN's - I'm thinking it was in case an inline item contained markup that could be a block level element and thus be invalid markup, but I'm really wondering if these could be SPAN's.
Comment #2
Agileware CreditAttribution: Agileware commentedYeah, that patch is a very basic fix and probably could be cleaned up a bit more.
I was also wondering about a separator for the multiple values. Maybe having an option to set the separator.
Although that is a different issue all together and I don't believe cck has an option for that so it is probably really the end user's responsibility to override the theming in regards to that.
Comment #3
Jeff Burnz CreditAttribution: Jeff Burnz commentedOK, I committed this to the 6.x-2.x branch to at least fix the bug - hooray. For later branches and versions I've started work on cleaning the whole thing up and will probably do something a little different.
Yeah, I'm not so keen on more places where users can input stuff and probably don't want to add any more theme settings (phew, its hard enough managing what is there already). In D7 this whole shebang needs a rethink and I need to look at how the field formatters work and think about how contrib might add to or extend formatters.