Hello,

Here's a patch that creates a .install file and adds the reporting at the admin/reports/status that upload progress is enabled. The invocation of hook_requirements() overrides the filefield reporting and eliminates the annoying "You need Apache for...".

The install also invokes hook_update_N() so that the module weight is updated in a way that comes after the filefield module.

Improved the README also.

Thank you for the module,
António

CommentFileSizeAuthor
#2 install_reports_status.patch7.11 KBperusio
install_reports_status.patch8.71 KBperusio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smoothify’s picture

smoothify CreditAttribution: smoothify commented

Thanks for taking the time to create this patch and help improve the module.

After taking a quick look through it, my one concern is in the requirements check. It seems to check for the pecl module and/or the apc implementation and if they are present returns a TRUE value? When using nginx these may or may not be enabled, either way they don't affect the upload progress since nginx doesn't pay any attention to them.

If i'm missing something - please let me know?

Thanks again

Ben

perusio’s picture

perusio CreditAttribution: perusio commented
FileSize
install_reports_status.patch7.11 KB

Hello Ben,

Well you're not missing something, I am. I should have RTFM. In fact I was under the impression that it depended on either APC or uploadprogress. I have both extensions enabled. I can remove the later now. I've learned that so far. In fact it just requires a PHP version after 5.2.0 as per the filefield requirements. Apart from that only the compilation of the nginx upload progress is required. Thank you for correcting my incorrect assumptions.
In fact I should have read the module file, since there you unset the handling of the APC upload progress that filefield uses.

Here's the patch against 6.x-1.1. Altered both the README and .install file. Much, much simplified the logic in hook_requirements().

Thank you,
António

smoothify’s picture

smoothify CreditAttribution: smoothify commented

Hello António

This patch looks much better, I will review this properly in the next day or two and then commit.

Thanks again for your time and interest on this issue.

Ben

smoothify’s picture

smoothify CreditAttribution: smoothify commented
Title: Patch to support reporting at the status report page in Drupal » Improve documentation and status reporting for upload progress.

Changing title

smoothify’s picture

smoothify CreditAttribution: smoothify commented
Status: Needs review » Fixed

This has now been commited:

http://drupal.org/cvs?commit=419046

Thanks for the creating the patch :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

perusio’s picture

perusio CreditAttribution: perusio commented
Title: Improve documentation and status reporting for upload progress. » Status reporting for upload progress.
Status: Closed (fixed) » Active

Hello,

I didn't check the issue queue recently. Today I upgraded the module to version 1.2 first and then to dev but the status reporting part of the patch is not there. The commit is just for the README.

Do you have any plans to include the status reporting part of the patch?

Thank you

smoothify’s picture

smoothify CreditAttribution: smoothify commented

Hi Perusio

Sorry that is my fault, the install file has been sitting in my folder but I hadn't done CVS add on it.

Now this is done and committed so its in CVS. Tonight / tomorrow the dev release should be re-rolled and that should include it.

Thanks for reporting this, and for your original work on this.

smoothify’s picture

smoothify CreditAttribution: smoothify commented
Status: Active » Fixed

A new release, 1.3, has been made that contains these changes.

Thanks again for your work on this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.