Hi, thanks for this great module. It seems like every major social-networking site would use a module like this to keep a collection of favorites for a user.

I'd like to suggest that you make the favorite_node_get() funciton for this module 'public' (remove the leading underscore) so themers and other module don't have to rewrite a fetching script. Rounding out this feature, I'd also like to see the complement to this function where you pass in a node and it returns a list of users. I've attached a patch with these changes, please consider adding them to your module!

Thanks! -Nathan

CommentFileSizeAuthor
#2 favorite_nodes_db.patch.txt2.51 KBaaron
#1 favorite_node_db_0.patch1.64 KBquicksketch
favorite_node_db.patch1.68 KBquicksketch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
FileSize
favorite_node_db_0.patch1.64 KB

Hmm, the query in the first patch is bunk. Here's a proper retrieval of user data.

aaron’s picture

aaron CreditAttribution: aaron commented
FileSize
favorite_nodes_db.patch.txt2.51 KB

+1 to this patch. although it should have favorite_nodes_get always return at the very least array(). patch submitted.