Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
the replaced tabledrag.js stopped functioning when I upgraded to jquery_update to use jQuery 1.4.2
Attached is a patch that resolves the issue with drag+drop in tabledrag.js.
Comment | File | Size | Author |
---|---|---|---|
#8 | tabledrag_1.5.patch | 805 bytes | stackpr |
jquery_update-1.4.2-tabledrag-compatibility.patch | 1.18 KB | bmcmurray | |
Comments
Comment #1
mark. CreditAttribution: mark. commentedYou are awesome!! Thank you!! I thought I was going to have to be stuck with 1.2.
Comment #2
sunI think this is a duplicate of #775162: tabledrag.js missing core patches, errors with nested <table>s
Comment #3
realityloopI'm re-opening this as the supposed duplicate is closed but the issue remains in dev download dated 2010-Sep-09..
I can confirm this patch works with both the packaged version of jquery, and jquery 1.4.2 when applied to jquery_update.module,v 1.5.2.2.2.4 2009/04/23 version of jquery_update, but not with the 2010-Sep-09 that is currently available
Comment #4
realityloopbumping version
Comment #5
alanburke CreditAttribution: alanburke commentedTested this patch with the patch at
http://drupal.org/node/685060#comment-3560918
I removed the tabletag changes in that patch [as they weren't working for me either].
It doesn't appear to be working.
The table rows can be 'dragged' but not 'dropped'.
Tested on firefox 3.6 Mac
Comment #6
squarecandy CreditAttribution: squarecandy commentedThe current stable 6.x-1.1 was not actually replacing tabledrag.js
switched to 6.x-2.x-dev - now it's replacing the file, but my drag handles are still missing from admin/build/block, etc...
Used this hack on tabledrag.js:
http://drupal.org/node/784266#comment-2996288
Working for me on the block admin page - dragging, dropping saving.
Haven't if this will have a negative impact elsewhere that tabledrag is used...
Comment #7
mraaroncruz CreditAttribution: mraaroncruz commentedThis patch works for me with jQuery v1.5!!
The problem seems to be that in jQuery >= 1.4, $.size() always returns at least 1 instead of 0 like the buggy script expects.
Thanks for the great patch! This would have taken me a long time to find...
Comment #8
stackpr CreditAttribution: stackpr commentedI experienced the same problem with jQuery 1.5.1. The drag handles did not appear throughout the CCK interfaces. I adjusted tabledrag before noticing this issue existed. This patch seems to address the same issue (in the same spot in the code) but sticks with .size() as some people prefer that style... The size() bug referenced in #7 may just apply to calls after append()?? Tested on FF3.6 (win/lin).
Comment #9
stackpr CreditAttribution: stackpr commentedCorrected the status -- there are 2 viable patches on the issue.
Comment #10
pifantastic CreditAttribution: pifantastic commented@witti's patch worked for me :) Muchos gracias.
Comment #11
smoothify CreditAttribution: smoothify commentedThis patch worked for me using the 6.x-2.x release along with jQuery 1.7.
Thanks @witti
Comment #12
elioshConfirm patch in #8.
Using jQuery 1.7 with module version = "6.x-2.0-alpha1+7-dev"
Comment #13
pitxels CreditAttribution: pitxels commentedAlso Confirm patch in #8.
Using jQuery 1.7 with module version = "6.x-2.0-alpha1+7-dev"
Please commit
Comment #14
rbayliss CreditAttribution: rbayliss commentedPatch in the OP seems cleanest, but really either one would do. This fixed tabledrag in both hierarchical and flat implementations for me.
Comment #15
pebosi CreditAttribution: pebosi commented#8 works for me too with jQuery 1.7 and dev version.
Comment #16
KarlSheaConfirmed #8 fixes tabledrag with jQuery 1.7 and dev.
Comment #17
markhalliwellDrupal 6 reached EOL (end-of-life) on February 24, 2016.