Country-Province ajax isn't called during page load

There is indeed a case when the province is shown as a regular text field. I did not know when it would happen because CCK did not work right for me for a long time. Now it works, but I don't have much time to work on the module. I think also that the text field expects the abbreviated name only, which is not good. It should work with the full name too.

At least, I'll be able to test and see whether I can reach that state too.

Thank you for your report.
Alexis

Can you copy the error here? Is it a box appearing in your browser, an error in the error log or in your HTML server?

Thank you.
Alexis

This looks like a 301. You should not get a 301 on an AJAX call...

The function being called is in addresses.settings.inc around line 272.

function _addresses_province_ajax()

But I think that if you get a 301 the AJAX may have a "no-follow" policy (which would make sense) so that would be the problem.

Do you have Global Redirect maybe?

Thank you.
Alexis

The q=... will be redirected by Global Redirect. I'm not too sure why it would work on your localhost, unless you did not setup the clean URLs on the localhost?

To fix the problem we need to change the JavaScript code in addresses.js. First, if you don't mind, I'd like you to test this:

Change the current code:

    $.ajax({
      type:'GET',
      url:Drupal.settings.basePath,
      success:updateProvinceField,
      dataType:'json',
      data: {
        q:'addresses/province_ajax',
        country:$(countryElement).val(),
        field_id:provinceElement.attr('id'),
        field_name:provinceElement.attr('name'),
        passback:provinceElement.parent().attr('id'),
        province:provinceElement.val()
      }
    });

to this code, which uses the clean URL and no q parameter:

    $.ajax({
      type:'GET',
      url:Drupal.settings.basePath+'/addresses/province_ajax',
      success:updateProvinceField,
      dataType:'json',
      data: {
        country:$(countryElement).val(),
        field_id:provinceElement.attr('id'),
        field_name:provinceElement.attr('name'),
        passback:provinceElement.parent().attr('id'),
        province:provinceElement.val()
      }
    });

If that works, we need to check whether you have clean URLs turn ON or not and adjust the code accordingly.

Thank you.
Alexis

Any news on this? I have the same problem here.

If anyone is still interested in why this isn't working, check your jQuery version.

It works with jQuery 1.2.6 . It failed when I tried the latest (1.6.1). The jQuery AJAX error callback claims "parsererror".

I get the same problem with version 1.12!

Any idea how it can be fixed....?

My JQuery is 1.2.6 by the way...

As with #12 above, I am seeing this problem with a CCK field after upgrading from 1.10 to 1.12. jQuery is version 1.2.6.

Looking at the console with Firebug, I can see the following GET (which returns with a 200):
/?q=addresses%2Fprovince_ajax&country=top_us&field_id=undefined&field_name=undefined&passback=undefined&province=undefined&language=en&attributes=%7B%7D

I'm guessing that "undefined" for field_id, field-name, passback, and province is at heart of the problem.

Looking at the resulting JSON, it contains quite a lot of "undefined" as well:

<label for="undefined">State / Province: </label><select id="undefined" name="undefined" class="addresses-province-field" ><option value="AL">Alabama</option>....

I just verified this same issue on a different Drupal 6 site (e.g. completely different server). As with above, it is address module 1.12 and jQuery 1.2.6. The AJAX call includes "undefined" for field_id and field_name, and the province is remaining a text input.

I found a fix for this issue.

It seems that css classes need to be added to the input elements for the javascript to work, and they were not getting added for me when using the addresses cck field on a content type.

I found a fix: I could add code that adds the css classes to the end of the addresses_elements_process function, and this fixed the issue:

  // Add the extra fields to the element and return it.
  $element = array_merge($element, $extra);
 
  if (!empty($element['country'])) {
    $element['province']['#attributes']['class'] .= ' addresses-province-field';
    $element['country']['#attributes']['class'] .= ' addresses-country-field';

  } 
 
  return $element;

I've attached a patch.

That would make sense. 8-)

However, you patch lacks a few test. If you look closely in the addresses.settings.inc, both 'country' and 'province' need to be defined. Also, the '#attributes' or 'class' parameters may not be defined. This means doing a .= will generate notices (E_NOTICE errors.)

This being said, if it works for others, then we're on the right track!

Thank you.
Alexis

I had the same problem, and 6.x-1.x-dev (I used the one dated 2011-Dec-12) seems to fix it. Thanks.

I'm having this problem as well, although it seems to be intermittent. I'll add more information when I can.
I'm using 6.x-1.12+7-dev