Clone lets you exceed the max character length for a menu, then you're stuck [#902612]

Hi,

Thanks for putting in the work on this module. Very useful.

Just wanted to point out one thing: the module lets you set the character length of the machine name of the cloned menu to be longer than the limit of characters. Then, when you try to do anything, including changing the menu title or deleting the menu, you get the error:

The menu name can't be longer than 27 characters.

So now I'm stuck with some menus I don't want unless I go in through the database.

I hope that helps.

Comments

Comment #1

malc0mn CreditAttribution: malc0mn commented 22 September 2010 at 17:57

Assigned:

Unassigned

» malc0mn

looking into this now...

Comment #2

malc0mn CreditAttribution: malc0mn commented 22 September 2010 at 18:06

Status:

Active

» Fixed

The problem was, as usual, quite silly:

  <?php
  $form['menu_name'] = array(
    '#type' => 'textfield',
    '#title' => t('Menu name'),
    '#default_value' => $menu['menu_name'],
    '#maxlength' => MENU_MAX_MENU_NAME_LENGTH_UI,
    '#description' => t('The machine-readable name of this menu. This text will be used for constructing the URL of the <em>menu overview</em> page for this menu. This name must contain only lowercase letters, numbers, and hyphens, and must be unique.'),
    '#required' => TRUE,
  );
  ?>

On submit the menu name is prefixed with 'menu-', so the correct code should be:

  $form['menu_name'] = array(
    '#type' => 'textfield',
    '#title' => t('Menu name'),
    '#default_value' => $menu['menu_name'],
    '#maxlength' => MENU_MAX_MENU_NAME_LENGTH_UI  - strlen('menu-'),
    '#description' => t('The machine-readable name of this menu. This text will be used for constructing the URL of the <em>menu overview</em> page for this menu. This name must contain only lowercase letters, numbers, and hyphens, and must be unique.'),
    '#required' => TRUE,
  );

The issue was fixed and added to the new b4 release.