Produce output only for nonempty view

I really want to see this bug corrected!

Now I am using Header field in my views instead of Viewfield's one, but it's a workaround, not a solution.

Would love to see this bug fixed !

I think we may find a solution inside the file viewfield.theme.inc inside viewfield module near line 112.

function theme_viewfield_select($element) {
  if (!empty($element['#children'])) {
    $field = $element['#field_info'][$element['#field_name']];
    if ($field['multiple'] && $element['#delta'] == 0) {
      // This is needed only for multiple viewfields.
      drupal_add_css(drupal_get_path('module', 'viewfield') .'/theme/viewfield.css');
    }
    return '<div class="viewfield-select">'. $element['#children'] .'</div>';
  }
}

I'm a noob in php… So please help us!

No, a real checking for field emptiness performed in the CCK module, in the 2390th line of content.module file. If $field_empty is set, the label of field is not diplayed.

The 'call_user_func_array' call is VERY slow, so maybe it worth to call it once, something like:

     array_unshift($view_args, $view_name, $display);
     $output = call_user_func_array('views_embed_view', $view_args);
+    if (!stristr($output, '<div class="view-content">')) {
+        $output = NULL;
+    };
     // This node is "safe" again.

Can you check this code? It is a dirty hack, but it works for me.

> I think the problem with checking the result of function views_embed_view is that it will not be empty even if the view has no result...

Exactly. Because views always renders output with $classes string (defined in views-view.tpl.php file and used in standard views templates) even for empty results. So Viewfield module really have to check the view for emptyness before passing results to CCK.

P.S. I just messed up a bit my templates, but now your (and mine) patch works flawlessly. I think, maintainer should include your patch into the next release.

Patch in #10 is working for me. I don't see performance issue here. Thanks a lot.

Please try this patch. Please note it's written for version 6.x-2.x.

Didn't test it, but looks good to me.

Commited in http://drupalcode.org/project/viewfield.git/commit/48ad659 and http://drupalcode.org/project/viewfield.git/commit/76a34b5.

This may or may not be intended behavior, but this fix doesn't print the empty text or the header if the 'display even when empty' option is checked.

Right now, the only thing I have available for empty / header text is a global text area so I changed my theme function to:

if ($view->result) {
  $output = $view_output;
} else {
  if (!empty($view->display[$view->current_display]->display_options['empty']) {
    $output = $view->display[$view->current_display]->display_options['empty']['area']['content'];
  } 
  if ($view->display[$view->current_display]->display_options['header']['area']['empty'] = 1) {
    $output .= $view->display[$view->current_display]->display_options['header']['area']['content'];
  }
}

This gets me to functionality equivalent to views, but it's dang ugly and most likely incorrect to do it this way. Not sure what the 'right' answer is.

@WorldFallz: I can reproduce your problem but the my views data structure looks slightly different than the one you seem to be working with. What version of views are you using? I tested with the latest release 6.x-2.12.

Ah... good question, I forgot to include that. I'm using the latest dev of views 6.x-3.x.

As you say, the approach is ugly and possibly incorrect, plus the views data structure changed from 2.0 to 3.0. Adapted for the two versions, this is the closest I got:

$view_output = $view->preview($display, $view_args);
// Check to make sure views returned real content so we don't produce
// just wrapper divs containing no content.
switch (floor(views_api_version())) {
  case 2.0:
    $header_display = $view->display[$display]->display_options['header_empty'];
    $footer_display = $view->display[$display]->display_options['footer_empty'];
    $empty_display = !empty($view->display[$display]->display_options['empty']);
    break;
  default:
    $header_display = $view->display[$display]->display_options['header']['text']['empty'];
    $footer_display = $view->display[$display]->display_options['footer']['text']['empty'];
    $empty_display = !empty($view->display[$display]->display_options['empty']['text']['content']);
    break;
}

if ($view->result || $header_display || $footer_display || $empty_display) {
  $output = $view_output;
}

Not exactly an elegant reliable solution.

I have rolled back the commit from #19 and changing this back to a feature request.

at least it's a theme function, so it's easily overridden on an as needed basis. i just have no clue what the 'right' answer is.

sub

fyi the problem is still there (the label prints for empty views)-- the code has changed some (there is no theme directory-- the theme function is now in the .module file).

this is what I'm using now as an override:

function theme_viewfield_formatter_default($element) {
  // $_viewfield_stack keeps a record of the current node to prevent infinite
  // recursion during the view rendering process.
  global $_viewfield_stack;

  $node = $element['#node'];

  if (!empty($element['#item']['vname']) && !isset($_viewfield_stack[$node->nid])) {
    // Push id of current node unless it's a new node being previewed.
    if ($node->nid) {
      $_viewfield_stack[$node->nid] = $node->nid;
    }

    list($view_name, $display) = explode('|', $element['#item']['vname'], 2);
    $view_args = _viewfield_get_view_args($element['#item']['vargs'], $element['#node']);


    // Render the view like Views would do.
    // @see views_embed_view()
    $view = views_get_view($view_name);
    if ($view && $view->access($display)) {
      // Override the view's path to the current path. Otherwise, exposed views
      // filters would submit to the front page.
      $view->override_path = $_GET['q'];

      $output = $view->preview($display, $view_args);
    }

    // This node is "safe" again.
    if ($node->nid) {
      unset($_viewfield_stack[$node->nid]);
    }

    // Only return an actual view result to not break empty value behavior.
    if ($view->result) {
      return $output;
    } else {
      if (isset($view->display[$view->current_display]->display_options['empty'])) {
        return check_markup($view->display[$view->current_display]->display_options['empty']['area']['content'], $view->display[$view->current_display]->display_options['empty']['area']['format'], FALSE);
      }
      if ($view->display[$view->current_display]->display_options['header']['area']['empty'] = 1) {
        return check_markup($view->display[$view->current_display]->display_options['header']['area']['content'], $view->display[$view->current_display]->display_options['header']['area']['format'], FALSE);
      }
      if ($view->display[$view->current_display]->display_options['footer']['area']['empty'] = 1) {
        return check_markup($view->display[$view->current_display]->display_options['footer']['area']['content'], $view->display[$view->current_display]->display_options['footer']['area']['format'], FALSE);
      }
    }
  }
}

[edited to update the code for empty/header/footer]

This is the same problem like in #477244: View field not working correctly with empty views..

To fix this in correct field API way, view should be executed in hook_field_prepare_view(), check if it has any output and if not unset that item because the field is empty (empty view).

Checkout this patch (it fix this problem also): https://drupal.org/node/477244#comment-7510777

I'll mark this as duplicate.

Thanks fiftyz! That thread fixed the missing exposed filters / no results behavior for me. Ended up applying patch at comment #56: https://www.drupal.org/node/477244#comment-12081410

I was seeing empty strings for $variables['empty'] and $variables['exposed'] in hook_preprocess_views_view() whenever no results were returned given the current filter values. Works great now!