Exposed filter blocks are cached

It would be cool if there would be a update_N hook to set it.

Hello,

I'm not sure what update_N hook is =) but should I wait on the next patch before apply and testing?
Will existing exposed filter as blocks in Views 3 still have the issue without the below command?
UPDATE blocks SET cache = -1 WHERE module = 'views' AND delta LIKE '-exp-%'

Thanks!

Views 3 does not have stable versions so upgrade paths are not supported

I would personally like to have an upgrade path. If noone will have it i will write one.

This saved me many hours of hair pulling, thanks!

An upgrade path would be sweet (it look me awhile to figure out how to enter the command to make my current exposed filter blocks not cached), but the patch itself looks to do the trick with newly created exposed filter blocks.

whoops, I accidentally set it to RTBC but it looks like the maintainer would like an upgrade path before committing.
I hope this may find its way into the latest dev in the near future!

Thanks!

The update code looks fine.

I would suggest here to talk with merlinofchaos to bump the update function number. We want to keep it as parallel as possible over the three different versions.

Looks fine for me.

Worked great - thank you very much!

Typically I only actually use single quotes to quote strings in queries. I'm not sure if there are any ill effects of using double quotes, but I'd prefer to be consistent.

Rerolled due #635336: Remove unused fields from the view introduces views_update_6010() and changes requested in #13.

Back to RTBC

Just noticed one other nit:

+  return array(update_sql("UPDATE blocks SET cache = " . BLOCK_NO_CACHE . " WHERE module = 'views' AND delta LIKE '-exp-%'"));

Should have {} around the table name.

Also just generally on style, I prefer to use $ret = array(); $ret[] = ...; return $ret;

Updated patch based on #16

This causes notices; I think because views are loaded after the update but before schema has happened. It probably just means we need to add some notice protection to the method that compares schema to actual results.

(subscribe)

So this is rtbc now.

I thought this errors came from #635336: Remove unused fields from the view

Thanks for the great work! This works perfectly

subscribing

Committed to all D6 branches;

marking for porting to D7 because I suspect that update_sql() statement needs to be redone for DBTNG.

Ported and commited.

works nicely

/**
 * Correct the cache setting for exposed filter blocks.
 *
 * @see http://drupal.org/node/910864
 */
function views_update_6012() {
  $ret = array();

  // There is only one simple query to run.
  $update = db_update('blocks')
    ->condition('module', 'views')
    ->condition('delta', db_like('-exp-') . '%', 'LIKE')
    ->fields(array('cache' => DRUPAL_NO_CACHE));
  
  return $ret;
}

Since #235673: Changes to block caching mode not caught D7 updates the block cache mode automatically, so these type of updates aren't really necessary. I've backported that patch to D6 but no one's looked at it in ages :-/