Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If you use "Store downloaded files" and define a directory that does not exist it does not give any warnings that the directory does not exist so the users think this was OK.
When update then is running it throws a php stream warnings error messages for every po-file that it tries to save. The warnings are also hard for the end user to understand (read)
It then confirm that the import of languages was OK, but did not import any translation strings.
Comment | File | Size | Author |
---|---|---|---|
#4 | l10n_update_917036.patch | 1.64 KB | thePanz |
#3 | l10n_update_917036.patch | 1.62 KB | thePanz |
#1 | l10n_update-917036-1.patch | 1.47 KB | Sutharsan |
Comments
Comment #1
Sutharsan CreditAttribution: Sutharsan commentedThis patch will add submit handler to check for and create a directory the settings form is submitted.
I also revised the description of the download file path.
Comment #2
steinmb CreditAttribution: steinmb commentedGreat work!
Tested and reviewed. Works as expected and the code looks sound.
Comment #3
thePanz CreditAttribution: thePanz commentedI suggest using the "_validate" hook, we can then set the right Form item error message (if any).
Comment #4
thePanz CreditAttribution: thePanz commentedUpdated patch (fixed comment and file_check options)
Comment #5
Sutharsan CreditAttribution: Sutharsan commentedSensible changes, thanks! Patch committed.
Comment #6
thePanz CreditAttribution: thePanz commentedThank you Sutharsan :)