Overlay does not allow language switching [#918738]

Steps to reproduce:

Enable the Locale and the Overlay module
Add a new Language on Languages Configuration page (e.g. German)
Edit both languages and either
- Set language domains (e.g. "http://drupal7.dev" and "http://de.drupal7.dev")
- Or, set language prefixes (e.g. "" and "de")
Enable URL detection on the Detection & Selection page, configure URL detection to use "Domain" or "Path prefix" respectively.
To be able to tell the interface language, import translations for the 2nd language (e.g. drupal-7.0-alpha6.de.po)
Enable the "Language Block" (e.g. add it to the "content" region)
Navigate to some admin page and try to switch the language using the language switcher...
- With language domains the interface language will stay the same as it was
- With language prefixes and the patch in #759844: Overlay does not work with prefixed URL paths applied the overlay is removed
(In either case if you disable the overlay module -- or try switching language outside the overlay -- then language switching works.)

The priority for this is up for discussion considering that probably not an awful lot of admin users need to switch their interface language all the time...

Some notes:

This will probably also affects modules like the domain module which - as far as I remember - depends on being able to switch domains for configuration.
#284625: Non-localized links in translation table... would make way more sense if language switching while using the overlay module works.

Comments

Comment #1

Jeff Burnz CreditAttribution: Jeff Burnz commented 22 September 2010 at 00:56

Sub

Comment #2

plach

he/him

Italian

Venezia

CreditAttribution: plach commented 22 September 2010 at 08:25

Comment #3

bforchhammer CreditAttribution: bforchhammer commented 22 September 2010 at 11:27

After looking at some of the overlay javascript code I think there's two parts to this:

For language domains the hostname changes when switching domains; as far as I can tell that means that we have to either completely reload the page (i.e. not treat admin links on a different domain as admin links?), or load the language into the same overlay via a different mechanism (not sure that would be a good idea)
For language prefixes, I think language switching would work simply if the respective url was recognised as an admin link. At the moment a link to http://drupal7.dev/de/admin is redirected to http://drupal7.dev/de/admin#overlay-context= instead of http://drupal7.dev/#overlay=de/admin (which works fine). (Maybe a solution could be to populate the pathPrefix variable introduced in #759844: Overlay does not work with prefixed URL paths with a regex matching all possible prefixes?)

It's the first time I'm looking at the overlay module, so let me know if I'm completely off or missing something...