error messages on tracker page - tracker_node_delete() does not correctly act on node deletion

I found the following got rid of the errors:

line 53: if (isset($node->comment_count)) {
line 63: 'type' => check_plain(node_type_get_name(isset($node->type))),

and repeat the addition of isset() for each remaining error.

I can't reproduce this.

Can you give more details about your setup -- content types, comment settings, etc?

Same problem.

Interesting, there is actually no node with id 15 (see screenshot)

IIRC Tracker on D7 caches its own data about nodes. Could it be it has data about node 15, but you since deleted node 15, and it's not caught up?

Can you look at tracker module's tables?

Yes, I deleted them from both tables, there are no more notices

Ah... I rather wanted you to check what was in those tables!

I can reproduce it by creating and deleting a new node.

node 16, user 15

tracker_node

tracker_user

its all still there, I flushed cache und ran cron after deleting.
it's independent from the content type.

Confirming this.

I reproduced like this:

1. create a node. notice it's shown in the tracker
2. delete the node.
3. go to the tracker and see the error messages.

Adding description of the problem to the title.

The problem is here:

function _tracker_remove($nid, $uid = NULL, $changed = NULL) {
  $node = db_query('SELECT nid, status, uid, changed FROM {node} WHERE nid = :nid', array(':nid' => $nid))->fetchObject();

  // The user only keeps his or her subscription if both of the following are true:
  // (1) The node exists.
  // (2) The user is either the node author or has commented on the node.
  $keep_subscription = FALSE;

  if ($node) {

Tracker only cleans up its tables if there is no node. However, hook_node_delete() is invoked BEFORE core deletes the node, hence tracker's logic fails. See also #988030: Document correct sequence of hooks in node deletion.

Um, shouldn't tracker implement hook_node_delete like everyone else?

It does -- hook_node_delete calls the code above.

But I am guessing this was written before the change at #890790: deleting nodes does not delete their comments..

Tracker assumes hook_node_delete is invoked AFTER the node has been deleted. This is no longer the case, so tracker's query to see whether a node exists returns a positive, and then it erroneously decides to not delete its records.

Should this #950680: Multiple notices from tracker after deleting a node marked as duplicate ?
There 's also a patch there.

Marking this as duplicate of #950680: Multiple notices from tracker after deleting a node, the other issue is RTBC.