Follow up from Data's #922868: Don't allow commas in tag names.

When mapping terms to tag vocabularies and these terms contain commas, the terms will be at first not split up. Only when editing and saving the node they will be.

Fix coming.

Files: 
CommentFileSizeAuthor
#10 feeds-925264-10.patch933 bytescedarm
#1 925264-1_tags.patch887 bytesalex_b

Comments

Status:Active» Reviewed & tested by the community
StatusFileSize
new887 bytes

This is RTBC.

Status:Reviewed & tested by the community» Fixed

I am using FEEDS 6.BETA-10 and still have the problem, that TAGs from a CSV URL are not separated, as you can see in my Posting from yesterday:
http://drupal.org/node/957654

EDIT: When I use BETA-09 or BETA-08 the mapping works fine for the Taxonomy Terms in the CSV File! So I guess that http://drupal.org/cvs?commit=428902 should maybe removed or at least edited?

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

This is a really annoying change. Previously, when consuming RSS feeds that had comma-separated values (eg: keywords), and mapping these into a Tag vocabulary, this worked "as expected", and saved as individual terms. Now, it creates one big term, with all the terms squished together :/

Status:Closed (fixed)» Active

Im not sure if this is something new, but this has cropped up again when I updated a few weeks ago to 6.x-1.0-beta10. All of my taxonomy terms for feeds that have been updated (some 400k nodes) have all be squashed together. This is really annoy and cuts down on the functionality of my site: www.shoeidiot.com

Thanks for reading

-Matt

Status:Active» Fixed

On further digging I found why this change was implemented:

A related bug report:
http://drupal.org/node/957654

The first bug report:
http://drupal.org/node/922868

With both sides having valid points and reasons (Those that want commas in the terms themselves, and those who use commas to separate terms), and with my recognition of a "mini-mod" to change the taxonomy deliminator this would seem to be fixed. (Although personally, I'll just be rolling back to Beta9 for the time being).

My request would be: Could this become an option in a further build, one to allow commas in the term, and one to use them to separate values?

My main concern would be future mod updates that may render what ever fix I use to allow commas (or another deliminator) would then be rendered obsolete at some point, and cause problems down the road.

Thanks for reading; great module.

- Matt

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status:Closed (fixed)» Needs review
StatusFileSize
new933 bytes

I'd like to respectfully challenge this commit. I understand why it was done, but I don't think just stripping commas is the right answer. Parsers supply an array of terms, right? So why can't we use drupal_implode_tags() to properly store even weird tags in $node->taxonomy?

This patch reverts #1 and provides a replacement. Tested with tags from drupal_explode_tags(), supplied as an array from the parser:

  • this
  • somecompany, llc
  • and "this" w,o.rks
  • foo bar

I agree to use drupal_explode_tags().
Let's do it the standard way. :)

My suggestion for the 7.x version is here:
http://drupal.org/node/1039134#comment-4235274