Logo broken on all pages other that root [#92696]

The Druplicon in the Garland default theme is broken on all pages other than root (/).

Investigating, looks like logo output is something like:

<img src="files/color/garland-7354b0d8/logo.png" [...]

...which means its relative to current directory.

Seems page.tpl.php needed base_path specified on line 39 as in:

            if ($logo) {
              print '<img src="'. check_url($base_path) .  check_url($logo) .'" alt="'. $site_title .'" id="logo" />';
            }

Wohoo! Finally working (via PuTTY) on my dedicated Linux box. The command line is so powerful.

Attached is a patch. Works for me.

Comment	File	Size	Author
#4	color.module.logo.patch.txt	618 bytes	Rok Žlender
	page.tpl.php_1.patch	583 bytes	DaveNotik

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Heine CreditAttribution: Heine commented 3 November 2006 at 08:39

Status:

Needs review

» Closed (duplicate)

http://drupal.org/node/92003

Comment #2

DaveNotik CreditAttribution: DaveNotik commented 3 November 2006 at 18:28

Status:

Closed (duplicate)

» Needs review

That issue opened first, but this one contains more information and a patch. Figured it's best to approve/disapprove this patch.

Comment #3

Tobias Maier CreditAttribution: Tobias Maier commented 3 November 2006 at 19:32

i dont think that we need check_url() around $base_path, because we dont do that in the other themes:
bluemarine: http://api.drupal.org/api/HEAD/file/themes/bluemarine/page.tpl.php/source
pushbutton: http://api.drupal.org/api/HEAD/file/themes/pushbutton/page.tpl.php/source
garland: http://api.drupal.org/api/HEAD/file/themes/garland/page.tpl.php/source

I know that check_url($base_path) is already used in this theme, but it could be removed imho
and if you dont like that you could use base_path()

Comment #4

Rok Žlender CreditAttribution: Rok Žlender commented 4 November 2006 at 16:20

File	Size
color.module.logo.patch.txt	618 bytes

IMO this is a color.module problem. Because $logo variable should hold complete path to logo. If you look at bluemarine page.tpl.php it justs prints logo
<img src="<?php print $logo ?>

In color.module there is a function _color_page_alter where $logo is overriden but without base_path(). I think my patch should fix this.