The small plus buttons that expand a menu in the admin toolbar don't work when overlay is present on a page.

That's the only problem I've noticed with admin's support for overlay.

CommentFileSizeAuthor
#7 admin.patch438 bytesjurgenhaas
#1 admin-927944-overlay.diff772 bytesskwashd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

skwashd’s picture

Status: Active » Needs review
FileSize
772 bytes

The attached patch fixes the problem. The new <a> needs the overlay-exclude class to stop the overlay module hijacking the click event on it.

yhahn’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

drclaw’s picture

Status: Closed (fixed) » Active

I'm still unable to expand the menu items once the overlay has been accessed... Am I the only one...?

caschbre’s picture

Are you using the jquery_update module by chance? I'm running into a similar issue that is a combination of overlay, jquery_update, and admin.

#1064198: jQuery 1.5 and Devel Module

drclaw’s picture

Nope, no jQuery update. Just admin and overlay.

jurgenhaas’s picture

Version: 7.x-2.0-beta2 » 7.x-2.0-beta3
FileSize
438 bytes

Here you go, I finally found the real issue and the patch that resolves it is attached.

The problem is that there is a menu.data('disableMenu', true); being used when clicking on a link, which is required to prevent the menu.drilldown('setActive') being called, because otherwise the link wouldn't be opened. Normally, this is no problem, because a new page gets loaded and the assigned data gets lost anyway.

However, if overlay is active, the page doesn't get reloaded and the data disableMenu=true remains assigned to the menu which prevents further execution of menu.drilldown

Well, I believe that disabling the menu is only required once, so the solution in the patch just unsets that setting immediately and I now have it working nicely and as expected.

paulgemini’s picture

Didn't fix it for me.

nithinkolekar’s picture

Issue summary: View changes

#7 patch worked with 7.x-2.0-beta3+8-dev , Jquery > 1.7 and Drupal core 7.34.