Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dvasquez’s picture

Status: Active » Closed (works as designed)

XQSme, i only set it to Block display, jejeje!

toddwshaffer’s picture

To clarify:

in /admin/settings/disqus underneath the Visibility section, choose the Block option in the Location dropdown menu.

Then you just select the "Disqus Comments" block from within the panels interface under the Miscellaneous tab.

That's it, your disqus comments should now be displaying properly.

dvasquez’s picture

Exactly, thanks for clarify it, toddwshaffer.

Anonymous’s picture

Version: 6.x-1.6 » 7.x-1.x-dev
Assigned: Unassigned » valor
Status: Closed (works as designed) » Active

Now when one can disable the Block module and only run with Panels, it makes sense to define a pane for the Disqus functionality.

Patch is coming soon.

Anonymous’s picture

Assigned: valor » Unassigned
Status: Active » Needs review
FileSize
1.57 KB

attached

wiiiktor’s picture

What is the effect of this path?

I put this into the code, but i don't see option --Display Disqus comment box in a pane-- to switch on...

My colution is to use a Custom block and choose a block with a DISQUS code copy / pasted from the disqus.com site (only the html filtering needs to be switched off).

rickmanelius’s picture

I don't understand why we won't assume the block module is enabled but we do assume that ctools is present. Why not simply make a 'block' module dependency and therefore we can assume that the block will always be available to panels.

rickmanelius’s picture

Status: Needs review » Needs work

Also, the patch in #5 does apply cleanly (awesome!) but as the comment in #6 asks, it's unclear how it actually works. I tried finding it in the panel and I can't seem to locate where to enable, etc. Putting to 'needs work' so that testers can then give this a proper review.

valor’s picture

You will find it under Disqus in Panels popup, try clearing your cache after applying the patch.

rickmanelius’s picture

FileSize
25.21 KB
22.18 KB
21.59 KB

Hi Valor,

I flushed cache twice and revisited the panels pop up. I only see the following (see attachments). Now in miscellaneous, I do see 5 disqus blocks available, but those were already there prior to this patch.

If I'm missing something obvious, please let me know and I'll be glad to get this reviewed. But right now, I'm still not seeing it.

valor’s picture

Status: Needs work » Needs review

Hi @rickmanelius
Did you apply the patch against 7.x-1.9 release or 7.x-1.x-dev ?
Try to apply the patch on the dev version if you are running 1.9

rickmanelius’s picture

Hi @Valor
The only differences between 7.x-1.9 and 7.x-1.x-dev are timestamps and the 1.9 versus dev label.

valor’s picture

Just so we can be sure try to run it against the DEV
Second make sure this files exists
/modules/disqus/plugins/content_types/comments/comments.inc
Are you passing any context to the panel ?

rickmanelius’s picture

Status: Needs review » Reviewed & tested by the community

Hi Valor,

The thing I was over-looking (or making a mistake, depending on your perspective) was the context portion. While the issue summary did state that one of the intentions was replacing nodes with panels, it wasn't clear if the solution here was to provide the ability to add disqus comments to a generic panel. If I had more experiencing on the programmatic side of ctools plugins.

So I can validate that yes the patch in #5 does indeed work... and provides disqus integration without the need of the block system.

Now if there was a way to meet the use case where a disqus thread could be added to a generic pane, that would be sweet. I have a situation where a client wants to have a custom panels page with a thread present on the homepage, which is not associated with any particular node. But alas, we'll save that for another thread once this is committed.

Thanks for your patience! Setting to RBTC.

sillygwailo’s picture

I noticed there was no "Settings" option for the pane when using this patch. Would it be possible to add that? Would love to add a title like "Comments" or "Join the Conversation".

SocialNicheGuru’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

This no longer applies

ziodave’s picture

FileSize
1.43 KB

I adapted the patch to current HEAD.

slashrsm’s picture

Looks OK. Can we add some comments to the actual plugin?

ziodave’s picture

FileSize
2.14 KB

Comments added.

torgosPizza’s picture

Status: Needs work » Needs review
DamienMcKenna’s picture

Rerolled.

DamienMcKenna’s picture

FileSize
4.12 KB

Adds the comment count plugin from #1857058: Create ctools pane for disqus comments.

DamienMcKenna’s picture

Status: Needs review » Reviewed & tested by the community
DamienMcKenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

  • DamienMcKenna committed ed5aee7 on 7.x-1.x
    Issue #928354 by DamienMcKenna, ziodave, sacred8, rickmanelius, dvasquez...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.