Hi

IMHO there is weird behaviour of elaboration text

If I send friend request to some user with elaboration text AAA, if he approve my request and he change this elaboration text, only his message is stored.
Maybe your idea (if this is a feature and not a bug) was that the second user can wrote his message under original text? But it is really not expected behaviour, nobody from people I asked about it didn't expect this behaviour and they all replace the original message with their new approved message. In this case the first message is not stored, what is pity, because often these messages have some value for requesters or requestee.

So the best could be when you can add new column into user_relationships_elaboration for the second (approving) elaboration message.

thanks a lot
Igorik

Comments

igorik’s picture

so when you will add the second column, we can to do, on approve form, the first message from requester as noneditable text and shown it only if it is not empty.

alex.k’s picture

Status: Active » Closed (won't fix)

That's just the way it's designed, i'm afraid. The field is the same for both requester and requestee.

igorik’s picture

I am surprised that you closed this idea immediately, probably Postponed could be better status because it is bad code in the module...

However, I fixed it temporarily by this css rule:

#user-relationships-ui-pending-requested #edit-elaboration-wrapper {
display: none;
}

as temp. fix, so there will be always the first message.

igorik’s picture

Status: Closed (won't fix) » Active

probably the most useful (and most easy for you) solution for you could be to shown the message from requester (if it is not empty) out of text area - above the textarea as the message from requesteer, and textarea for text from approver will be empty.
If approver will write something there, this text will be added together with the first message, after some sign, e.g. " | ", or "Approver's name: " and it will be stored same as before as one elaboration text.

What do you think about it? it will probably takes few minuites only to do this small changes.

thanks
Igor

mrf’s picture

Title: elaboration text - wrong behaviour » remove ability for requestee to modify original elaboration text
Component: Code » Elaborations
Category: bug » feature
mrf’s picture

I am postponing any 6.x feature requests that don't have a current applicable patch to help sort the large list of open features.

Please feel free to set to 'needs review' once a patch is included.

mrf’s picture

Status: Active » Postponed