There are two issues i found.
1) When the comment form is at the bottom of the thread, the comment links / buttons still refer to a new page to comment on the thread.
2) Using flat nodes, you can check a box in /content/node-type/forum to not show the comment link on comments. Because we use a flat list this would not be needed. But this check is ignored by AF.

Comments

Michelle’s picture

Title: Comment form bottom page, and, do not show comment link » Integrate with "flat nodes"
Category: bug » feature

The first one is by design. The second one would be a feature request. I've never heard of the "flat nodes" module. I'd be willing to look at a patch.

Michelle

Michsk’s picture

What do you mean is by design? When i look in advanced_forum.module @381 it states

      // Core only adds the link if the comment form is on a separate page
      // but we want the link there regardless for consistancy.
      // Nodecomment already handles this so only run if that's not enabled.

Since i do not use nodecomment and show the form at the bottom of the thread i want them to 'jump' down to the form and not send them to another page.

And i did not mean flat nodes but http://drupal.org/project/flatcomments

See the 2.X options
# Option to hide the reply link on comments. Note: Hiding the reply link only works with an unmodified links section. Ex. It does not work with Advanced forum currently but may in the future. See #374463: Alter comment links..
I don't know if the link issue must be placed here or at flatcomments issue queue.

Michelle’s picture

Title: Integrate with "flat nodes" » Make AF work with Flatcomments option to remove reply link

Oh, flatcomments. Sorry, that's what I get for triaging my queue when I'm half asleep. :)

#1 is by design, yes. As it says, it adds the link so that it is consistent. The rest of the posts have a reply link so the first one should, too.

#2 I can have a look at. I don't see any reason why it wouldn't work with the comments themselves. I'll need to add something so it doesn't add the reply link to the node if they are removed by flatcomments from the other posts.

Michelle

Michelle’s picture

Ok, I installed it and I see why it's not working. It needs #936040: Use hook_link_alter to remove comment reply link. Once it's using that, it should work fine. I do still need to add a check for it on the node, though, because it's only affecting comments. Otherwise we'd lose the consistency.

Michelle

Michsk’s picture

Im still not getting #1. Sure the firt post, thread, should also have a comment link. But, when we set the settings of our forum to show the reply/comment form at the bottom of the page the reply/comment links should point to the bottom of the page and not to a new page with the comment form. Am i maybe explaining it not good? If you need/want i can send screenshots.

Michelle’s picture

Status: Active » Postponed (maintainer needs more info)

I don't need screenshots. I understand you; I just don't agree with you.

Setting this postponed until the Flatcomments issue is fixed because there's no point in doing anything with the node until the comments are working.

Michelle

Michsk’s picture

But how can you not agree with me. The way i describe it here is the way drupal core works. So then you would not agree with core.

When we have a node_type and in that node_type set that the comment form is at the bottom of the page. The comment link in the node then does not point to a new page with a comment form, but to the bottom of the node where the comment form is located. So to be consistent, this should also be done with the forum.

Michelle’s picture

No, when you put the comment form on the bottom in core, it takes the link away. That's why AF adds the link. And it adds it in such a way as to be consistent with the rest of the posts on the thread because AF treats all posts the same.

If you'd like to do something different, you're welcome to use hook_link_alter. I'm not going to keep arguing about it.

Michelle

Michsk’s picture

im sorry, your right. Still think it should point to the bottom of the page tough ;)

Michelle’s picture

Status: Postponed (maintainer needs more info) » Active

A few notes...

To check if this node type has the reply hidden:

if (in_array('reply', variable_get('flatcomments_remove_reply_link_' . $vars['node']->type, array()))) {

Section of AF code affected:

      if (!module_exists('nodecomment')) {
        if ($node->comment == COMMENT_NODE_READ_WRITE) {
          if (user_access('post comments')) {
            if (variable_get('comment_form_location_'. $node->type, COMMENT_FORM_SEPARATE_PAGE) != COMMENT_FORM_SEPARATE_PAGE) {
              $links['comment_add'] = array(
                'title' => t('Add new comment'),
                'href' => "comment/reply/$node->nid",
                'attributes' => array('title' => t('Reply to this topic.')),
                'fragment' => 'comment-form'
              );
            }
          }
        }
Michelle’s picture

Status: Active » Closed (won't fix)

This isn't going to happen in D6. If it's still an issue in D7, it can be moved there.