I'm the active maintainer of Node Gallery. As the title suggest, it's a gallery module where each image in a gallery is a separate node.
Even in it's current form, this module hands down beats out every other bulk upload tool I've tried. I have code checked into our dev branch that integrates it perfectly.
However, the one deal-breaker that prevents me from shipping it is the fact that it doesn't currently work with IE8. There's some mention of that fact over in #880300: Decide on a plupload module roadmap, but I was wondering:
- How big of a priority is it to get IE8 compatibility into the 6.x branch?
- Has anyone started?
If no one has stepped up, I can see what I can do. I'm a backend PHP guy and feel uncomfortable doing JS/Flash, but I guess I have to learn it sometime :)
I would love any comments about prior attempts, potential pitfalls, etc.
Comment | File | Size | Author |
---|---|---|---|
#6 | plupload-flash.patch | 2.21 KB | justintime |
#4 | plupload-flash.patch | 2.92 KB | justintime |
#3 | plupload-flash.patch | 2.25 KB | justintime |
#2 | plupload-flash.patch | 2.22 KB | justintime |
Comments
Comment #1
gregglesIt seems fine to me to add that in. I don't think anyone is working on it.
Comment #2
justintime CreditAttribution: justintime commentedHere it is. Works good for me now in IE 8.
There's two changes not related to falling back to flash. The first is that the code from #947024: uploadQueue url needs passed through url() is included in this patch.
The other change is that instead of statically setting the file extension filters within the module, I load it from the filefield to make things a little more dynamic and integrated.
Comment #3
justintime CreditAttribution: justintime commentedWhoops - had a case where I need to pass the swf path through url() in order for it to work in node_gallery. Attached patch does that.
Comment #4
justintime CreditAttribution: justintime commentedIt turns out this feature uncovered #949950: Chunked uploads result in image fragments, and therefore depends on that being resolved to work properly. Here's a patch that includes everything you need for a Flash runtime upload (I hope).
Comment #5
gregglesIt looks like some extra newlines crept in:
This seems to still include the hunk for #949950: Chunked uploads result in image fragments.
Comment #6
justintime CreditAttribution: justintime commentedHere you go.
Any pointers on how to manage multiple patches on the same file while waiting for review?
Comment #7
gregglesUnfortunately I don't have tips for that :/
I guess I make the first patch, then use patch -R to help apply/remove it.
This looks great to me.
Comment #8
justintime CreditAttribution: justintime commentedCommitted.