Problem/Motivation
Was working on the comment module docs and noticed under the field type options to add onto the comment form "Boolean" is part of the list...talk about non-user-friendly UI text. I'm pretty sure my proposed label "Simple yes/no option" (based on the description already in the list module file) will be contested, but I'm moreso filing this just to note that it probably needs to be changed.
(Also maybe "float" needs to be modified but I don't have a good enough sense to warrant filing an issue there.)
Steps to reproduce
Proposed resolution
Closing as won't fix based on usability review, See #30
Change the label of the Boolean field type from 'Boolean' to 'Yes/No option'.
Before
After
Remaining tasks
1. Decide if this change should be made.
User interface changes
Yes, the label for the Boolean field.
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#27 | 951428_after_patch.png | 14.64 KB | vikashsoni |
#27 | 951428_before.png | 15.59 KB | vikashsoni |
#25 | 951428-25.patch | 730 bytes | quietone |
#25 | After.png | 36.72 KB | quietone |
#25 | Before.png | 23.02 KB | quietone |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedMoving this to 8.x
I can see why boolean is not that user friendly. But I don't think we need "simple" in the sentence.
Comment #2
aspilicious CreditAttribution: aspilicious commentedCan use a review
Comment #4
arianek CreditAttribution: arianek commentedlooks like i might have to dig into d8 and reroll ;)
Comment #5
yoroy CreditAttribution: yoroy commentedI need some practise too…
Comment #6
aspilicious CreditAttribution: aspilicious commentedStore or stores not both :)
I prefer stores.
Comment #7
yoroy CreditAttribution: yoroy commentedTrue
Comment #8
arianek CreditAttribution: arianek commentedI think the revised labels (from comment 7) read a lot better and makes more sense. :)
Was going to test the patch but apparently my MAMP's PHP is too old to run D8 so maybe later!
Comment #9
AaronBaumanSo now, instead of using the technically correct and accurate term "Boolean", we're going to change this to a recursively defined and not necessarily accurate "Yes/No Option"? I think we can assume that admins are smart enough to read the description directly below the word "Boolean" to figure out what it means. If we cannot make that assumption, then why do we have a description in the first place?
I don't argue that "Boolean" is the perfect label, but I do argue that "Yes/No Option" is worse.
Comment #10
superspring CreditAttribution: superspring commentedI think that the term 'Boolean' does need to stay in the name somewhere since programmers and developers will want to know how it's being stored in the database, rather than just an Enum with two fields.
Comment #12
Prashant.cComment #22
quietone CreditAttribution: quietone as a volunteer commentedComment #23
quietone CreditAttribution: quietone as a volunteer commentedHopefully, improving the title.
Comment #24
quietone CreditAttribution: quietone as a volunteer commentedOops, meant to change the component as well.
Comment #25
quietone CreditAttribution: quietone as a volunteer commentedAdded a before and after screenshot to the IS.
The attached patch is not a complete reroll, it just has label change for Boolean. The other changes in the patch are slight changes to the wording of the description for the fields that are in the D7 list.module.
Comment #26
quietone CreditAttribution: quietone as a volunteer commentedI meant to add that I asked for feedback on this issue in #ux. benjifisher responded asking for an updated screenshot, which I did in the previous comment. Also, I aborted the tests because I thought that can wait until after there is feedback.
Comment #27
vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented@quietone
patch apply successfully and boolen field label changed
Comment #28
quietone CreditAttribution: quietone as a volunteer commented@vikashsoni, thanks for your interest in this issue. However, #26 says that is waiting for feedback from the folks in #ux which mean there is nothing to do until that happens. Adding screenshots (which are duplicates of the ones I added about 3 1/2 hours before yours) is not advancing this issue. Therefor removing credit. The contributor guide on Drupal.org has information about the process to Review a patch or merge request.
Comment #29
AaronMcHaleAdding ux review tag, issued queued for review at #3216349: Drupal Usability Meeting 2021-06-11.
Comment #30
benjifisherWe discussed this issue at #3216349: Drupal Usability Meeting 2021-06-11. There were about 6 people present, with a variety of backgrounds: some who speak English as their first language, some not; front- and back-end developers, site builders, etc.
There was a pretty solid consensus that "Boolean" is the standard, recognized term for this sort of field, and we should leave this form as it is.
Part of the problem with "Yes/No" is that it is only one of several similar alternatives: 0/1, True/False, On/Off. In fact, when you add a Boolean field, you get to the settings page for the field (such as
/admin/structure/types/manage/test_content_type/fields/node.test_content_type.field_test_boolean_field
) and have a chance to fill in text for the '"On" label' and the '"Off" label'.One suggestion came up after the meeting to combine the options: "Boolean (Yes/No)" or "Boolean (True/False)". Personally, I do not like that option because parentheses are already used on the same list to describe variants: "Number (decimal)", "Number (float)", and so on.
Our recommendation is to close this issue as "won't fix". I will not do that just yet in case anyone else wants to respond.
Comment #31
quietone CreditAttribution: quietone as a volunteer commented@benjifisher, thank you for reporting back on the discussion.
Comment #32
AaronMcHaleComment #33
quietone CreditAttribution: quietone as a volunteer commentedIt has been just over a fortnight since the Usability review recommended that this should be closed as won't fix. It is always hard to know how long to wait but this has had little interest and those that commented did not agree. I think it is time.
Therefor closing as won't fix.