Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
If use non-ASCII character in tabs title, we get '-' in descriptive url, because there is preg replace '/[^\sa-zA-Z0-9\ ]+/ ' in code.
But we could have better urls for non-ASCII titles.
Transliteration module or pathauto_cleanstring can help.
Comment | File | Size | Author |
---|---|---|---|
#1 | 953904-tabs-transliteration.patch | 1.07 KB | pokurek |
Comments
Comment #1
pokurek CreditAttribution: pokurek commentedSmall patch for this.
Comment #2
pokurek CreditAttribution: pokurek commentedMy fault, I deleted tags, sorry :(, Put it back.
Comment #3
nedjoThanks!
Questions:
* Should we remove the configuration option? We added it as a configuration option partly because of the problems that our incomplete handling. If transliteration handles this, we could maybe remove the configuration option and, if transliteration is present, use a descriptive title, and if it it isn't not. Thoughts?
* Is our handling still needed if transliteration is present? I'd assume the
preg_replace('/[^\sa-zA-Z0-9\ ]+/ ', ' ', $title);
call should be in an else clause.Comment #4
pokurek CreditAttribution: pokurek commentedI try to answer questions:
* Configuration option could stay there. Someone may use the 'tab-index' tab name for styling or something else. Patch is only for make better the descriptive title. Maybe we should write description for that field, add mention about transliteration module.
* Yes, it should be in an else clause. I do it this way only for "make sure" title is clean ;o)