Please, find attached a patch in order to have in the view object the overall total_rows also when offset is enabled, in order to have each time full count of view result.

This patch a new property to views object "total_rows_full".

Let me know if is the correct approach.

CommentFileSizeAuthor
views_total_rows_full.patch1.93 KBpaolomainardi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review

This will definitive need a views3 patch

strk’s picture

strk CreditAttribution: strk commented

The patch looks good to me.
Any chance to see it in a 2.12 release ?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

.

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented

Dereine, why this issue is tagged on "needs work" ? There are possibilities that this patch will be included in the 6.x branch ?

Thanks a lot.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

See http://drupal.org/node/954464#comment-3632630

paolomainardi’s picture

paolomainardi CreditAttribution: paolomainardi commented

Do you ask me to produce a patch for views3 as well ? I don't fully understand if there any rooms that is patch will pushed to Views 2.x branch too.

Thanks a lot.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

It's a find patch for 2.x, because it doesn't brake anything. But there is a need for a patch for 3.x, because both branches needs this feature.

I hope this was understandable.

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)