Automatically delete feed items when feed node is deleted. [#954814]

It would be useful to have the option to automatically delete feed items when their associated feed importer node is deleted. This should be straightforward with hook_nodeapi(). Patch to follow.

Comment	File	Size	Author
#3	954814_3.patch	2.2 KB	Will White
#3
#1	954814_1.patch	2.21 KB	Will White
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Will White CreditAttribution: Will White commented 27 October 2010 at 18:20

Status:

Active

» Needs review

File	Size
954814_1.patch	2.21 KB

This patch add an option to the data processor. Similar options could be added to processors. During the "delete" op, hook_nodeapi() now checks for this option and runs clear() on the source if the option is true.

Comment #2

alex_b CreditAttribution: alex_b commented 27 October 2010 at 18:31

Status:

Needs review

» Needs work

Looks good.

A) Can we call this option 'delete_with_source' or sth similarily descriptive (not delete_with_node though)?
B) Title should be much shorter "Delete with source", description can stay the same.

This is surprisingly simple!

Comment #3

Will White CreditAttribution: Will White commented 27 October 2010 at 19:22

Status:

Needs work

» Needs review

File	Size
954814_3.patch	2.2 KB

Hi Alex,
Here is an updated patch with the changes you suggested.

Thanks,
Will

Comment #4

alex_b CreditAttribution: alex_b commented 28 October 2010 at 01:46

Status:

Needs review

» Needs work

Will... we should cover this with a test.

This functionality is going to go into the next MN release and it's going to be one of these things that we won't notice if it breaks. The test should be *very quick* to write. If you have any questions around it, please poke me.