Node type module key added to dependecies without checking validitiy [#961678]

Node module key doesn't actually need to correspond to anything (I believe that PDD book suggests using something other than module name for it in it's examples -- haven't read it but someone mentioned something like that), and also if module_key == current module, it gets added O.O!

Comment	File	Size	Author
	module_key_is_a_ruse.patch	774 bytes	hefox

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

wizonesolutions

he/him

English

Norway

CreditAttribution: wizonesolutions commented 4 September 2011 at 20:29

Confirmed patch applies. hefox, you're a co-maintainer now so you can just RTBC and commit if this is still worth it. Right? :D

Comment #2

hefox CreditAttribution: hefox commented 5 September 2011 at 00:02

Status:

Needs review

» Reviewed & tested by the community

Yep, for tiny patches like this one review seems good enough. Getting ready for a labour day dinner, so later :P

Comment #3

hefox CreditAttribution: hefox commented 5 September 2011 at 17:31

Status:

Reviewed & tested by the community

» Fixed

d7 now has the 'base' key now and 'module' corresponds to defining module (http://api.drupal.org/api/drupal/modules--node--node.module/function/_no...) and not directly from the code, so as far as I can tell this doesn't need to be ported.