Grammatical change to core-overrides.inc 'in -the- forum' [#962218]

We're developing a site that makes extensive use of this awesome module, and my partner pointed out what he believed was a grammatical mistake.

"Login to post new content in forum."

Now, I'm not an English major, but if I break the sentence down...

'Login' -- Verb

'to post new content' -- Prepositional phrase, setting up the predicate 'post new content' with the implied subject 'you'

'in forum' -- Another prepositional phrase, indicating the direction of the previous action.

Suggestion: add the word 'the.'
Because it makes this broken up collection of phrases feel better, and read better, and the whole sentence also reads a little better.

core-overrides.inc
411-422

if (empty($forum_types)) {
    // The user is logged-in; but denied access to create any new forum content type.
    if ($user->uid) {
      $forum_types['disallowed'] = array('title' => t('You are not allowed to post new content in the forum.'));
    }
    // The user is not logged-in; and denied access to create any new forum content type.
    else {
      $forum_types['login'] = array(
        'title' => t('<a href="@login">Login</a> to post new content in the forum.', array('@login' => url('user/login', array('query' => drupal_get_destination())))),
        'html' => TRUE);
    }
  }

Comment	File	Size	Author
#10	af7_962218_1.patch	953 bytes	troky
#10

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 4 November 2010 at 14:41

Sure, that makes sense. I never really thought about it... This comes from core forum. You might want to file an issue against core as well.

Michelle

Comment #2

carlthuringer CreditAttribution: carlthuringer commented 6 November 2010 at 04:08

Thanks for the quick response. It was a good opportunity to exercise my new Drupal muscles. I found that it says '... to post new content in the forum' in the core forum.module, so no issue will be necessary. Disappointing considering how exciting it would be to commit a patch for core. :D

With a bit more looking, I found #479216: Poor grammar in template_preprocess_forums, where jhedstrom beat me to it over a year ago. XD

Comment #3

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 6 November 2010 at 04:26

Ah, yeah, I haven't been good about keeping up with changes to core forum in the stuff I've overridden. Everything will get a thorough going over in the port to Drupal 7 and then I'll be backporting what I can to D6 like I did with D5 when D6 came out.

Michelle

Comment #4

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 5 December 2010 at 04:39

Status:

Active

» Closed (won't fix)

I haven't looked at core overrides in so many months that I just assumed the code you posted was in there. But it's not. If you look at the file you can see that it doesn't even have that many lines in it. You must be looking at a really old dev snapshot, I guess.

So, nothing to fix here.

Michelle

Comment #5

carlthuringer CreditAttribution: carlthuringer commented 5 December 2010 at 09:40

// $Id: core-overrides.inc,v 1.1.2.11 2010/03/25 04:45:56 michellec Exp $

You're right. Seems our production site is running on a pretty old dev snapshot. I'm stunned by how much is different. This makes me want to roll a fresh dev snapshot against our development server and see if there are any issues. Thanks as always.

Comment #6

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 5 December 2010 at 13:39

Oh, yeah, tons of differences since last march. This branch is in active development. I don't always have time to work on it but tend to make pretty big changes when I do.

Just don't update your production site to the latest dev. It's got some pretty broken spots. Wait for Alpha 4.

Michelle

Comment #7

carlthuringer CreditAttribution: carlthuringer commented 15 December 2010 at 07:25

Thanks for the heads-up Michelle. I'll wait for alpha 4. We're gradually nudging our development process in the direction of github and thankfully we're using Dev and Live instances too. On top of that, I've been hitting myself over the head with module development, features, and more so that 90% of the changes on Dev go to live via a module, not individual config changes. Difficult, but rewarding, as I can now deploy and test on a fresh live dump in only a few minutes.