destination address does not track account email change [#970936]

When a user changes their email address, the messaging destination address does not track. You have to change the send method in the account settings to something else, save, then change back.

IMHO the email addresses should track or messaging should always pull the account email address for any mail based messages.

Comment	File	Size	Author
#6	messaging-update-destination-970936-6.patch	3.72 KB	JoeMcGuire
#5	messaging-970936-5.patch	4.29 KB	univate
#4	messaging-970936-4.patch	5.94 KB	univate
#3	0001-970936-update-destination-address-for-mail-mimemail-.patch	7.09 KB	univate

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tbenice CreditAttribution: tbenice commented 13 November 2010 at 19:17

What's also not right is that the mail option test in messaging settings will send to the user's account address, but notifications messages are sent to the messaging_destinations address. There's a disconnect there someplace.

Comment #2

tbenice CreditAttribution: tbenice commented 21 January 2011 at 22:27

Priority:

Normal

» Critical

this is a truly annoying bug. i'm changing it to urgent. not sure how to address it.

Comment #3

univate CreditAttribution: univate commented 3 April 2011 at 03:31

Status:

Active

» Needs review

File	Size
0001-970936-update-destination-address-for-mail-mimemail-.patch	7.09 KB

See attached patch for a solution.

I have added a function to update addresses in the message_destination table for any message type and then in messaging_mail, messaging_mime_mail, messaging_phpmailer & messaging_sms added function to hook into user updating these details and update these.

I haven't used another other message types, so they may need to still be updated.

Comment #4

univate CreditAttribution: univate commented 3 April 2011 at 03:57

File	Size
messaging-970936-4.patch	5.94 KB

Here it is a normal patch as well.

Comment #5

univate CreditAttribution: univate commented 3 April 2011 at 05:18

File	Size
messaging-970936-5.patch	4.29 KB

Actually seems the fix is a little simpler then I first thought and don't need to repeat the changes for mime_mail and phpmailer as they inherit the messaging_mail destination, so I can remove half the changes from the above patch.