Subtheme documentation issue [#971640]

It appears that this line in the subtheme documentation is erroneous:

" 4. Within the file of theme_settings.php line 16: function opengrid_subtheme_settings ($ saved_settings) -> aquarius_subtheme_settings ($ saved_se" ....

In order to get the theme settings form to show up for my subtheme, the function needed to be named mytheme_settings(), not mytheme_subtheme_settings() as the documentation suggested. Once I changed the function name to mytheme_settings, everything worked as expected.

FYI, this is a very interesting theming concept and solves some, but not all, of the headaches we have had with 960, fluidgrid, etc in the past. Well done.

Comments

Comment #1

mauro72 CreditAttribution: mauro72 commented 15 November 2010 at 13:01

Thanks higherform for your observation, I just fix the error and will be committed in the next release. Let me know about the unsolved headaches, maybe the theme can be improved to provide a better grid system.
Greetings.

Comment #2

higherform CreditAttribution: higherform commented 16 November 2010 at 14:07

So far the most helpful thing would be to clear the css unnecessary selectors and rules. For example, .header-region * { display: inline } .header-region .block * {display: inline} , etc select everything underneath them and really do not need to be there to make the grid framework happen... it just means we have to copy and override/delete vast portions of main.css...

Comment #3

higherform CreditAttribution: higherform commented 16 November 2010 at 16:59

Two more suggestions:
Provide a complete set of default settings for 24 column grids either in the same or an alternate theme-settings.php

Have footer-region clear both

Comment #4

mauro72 CreditAttribution: mauro72 commented 17 November 2010 at 22:24

Thanks for your suggestions, I'm kind of busy by now but I'll keep them in mind for the next release. If you have more ideas do not hesitate in tell me about them, your feedback is very helpfull.

Greetings.

Comment #5

Mojah CreditAttribution: Mojah commented 28 March 2011 at 01:22

Status:

Active

» Fixed

Default settings for 12 and 24 column layouts added to 3x branch and css organized in such a way to help designers easily customize the theme for their design.