The search within group uses a GET method, which is good in terms of efficiency, but litters the URL with form_id, token, etc.

We don't actually need a full form here since the search is just based on the URL, so we can bypass a lot of FAPI for a better end experience.

CommentFileSizeAuthor
#3 973812-search-url-cleanup-3.patch1.54 KBpwolanin
#2 973812-search-url-cleanup-2.patch1.62 KBpwolanin
#1 973812-search-url-cleanup-1.patch1.52 KBpwolanin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Status: Active » Needs review
FileSize
973812-search-url-cleanup-1.patch1.52 KB
pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
973812-search-url-cleanup-2.patch1.62 KB

better patch - missed one step of from preparation.

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
FileSize
973812-search-url-cleanup-3.patch1.54 KB

We don't actually need the element info.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno commented
Title: Search within grop form gives a dirty URL with token, etc. » Search within group form gives a dirty URL with token, etc.
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Title: Search within group form gives a dirty URL with token, etc. » Remove form_id, token, etc from the group form URL
Issue summary: View changes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs review » Postponed

The only development done on groups.drupal.org is to replace it. The plan seems to migrate it into drupal.org, as described in #2590497: [meta] Proposal to migrate groups into Drupal.org.