Filename transliteration: Space replaced by underscore rather than defined separator character [#973936]

When using the transliteration function for file uploads, an original space character gets replaced by underscore. This seems to be hardcoded.

It would be fine if one could define its own separator character and omission rules for file renamings (as for the URL aliases) or to have a setting, which allows to use the same rules for both.

Because eventually files will also be referred by URLs! And wouldn't it be nice to have the same universal separator throughout your whole site for both URL aliases and filenames (which eventually also get URLs somewhere)? Example: "/my-little-node" and "/files/my-little-file.txt".

Original: Aaa Bbb Ccc.txt
Result: aaa_bbb_ccc.txt
Expected: aaa-bbb-ccc.txt

Comment	File	Size	Author
#5	transliteration-spaces-973936-5.patch	2.34 KB	imclean

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

eL CreditAttribution: eL commented 18 November 2010 at 15:11

Comment #2

Slovak CreditAttribution: Slovak commented 18 January 2011 at 21:26

You could edit line 82 of transliteration.module to read:

$filename = str_replace(' ', '-', $filename);

The difference being in the str_replace from '_' to '-'

Perhaps if function transliteration_clean_filename would have another variable that could be set in template.php which would define the character to use for replacement in filenames?

Comment #3

mibfire CreditAttribution: mibfire commented 20 May 2011 at 09:44

Comment #4

sachbearbeiter CreditAttribution: sachbearbeiter commented 26 May 2011 at 12:39

Comment #5

imclean CreditAttribution: imclean commented 29 June 2011 at 02:16

Version:	6.x-3.0	» 6.x-3.x-dev
Status:	Active	» Needs review

File	Size
transliteration-spaces-973936-5.patch	2.34 KB

Good idea. Here's a patch which provides some configuration options regarding spaces. It defaults to the current behaviour, with options to keep spaces, remove them altogether, or replace them with either an underscore or dash character.