Strict warnings [#974542]

I've created a page display using fields, and node type as filter.

As fields I've selected all 6 of the fields for the content type as well as the node title.

Upon saving, the module says:

Strict warning: Declaration of views_handler_field_field::pre_render() should be compatible with that of views_handler_field::pre_render() in require_once() (line 34 of /Users/me/Sites/drupal/sites/all/modules/views/modules/field/views_handler_field_field.inc).

When viewing frontend, it says:

# Strict warning: Declaration of views_handler_field_field::pre_render() should be compatible with that of views_handler_field::pre_render() in require_once() (line 34 of /Users/me/Sites/drupal/sites/all/modules/views/modules/field/views_handler_field_field.inc).

# Strict warning: Only variables should be passed by reference in views_handler_field_field->render() (line 198 of /Users/me/Sites/drupal/sites/all/modules/views/modules/field/views_handler_field_field.inc).

That last message repeats equal to the number of fields

Comment	File	Size	Author
#2	974542-notice-pre_render.patch	5.46 KB	dawehner
#2
	Screenshot from the view settings	117.42 KB	phobia

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 17 November 2010 at 17:27

Marked #894274: E_STRICT pre_render as duplicate.
This issue has more informations.

Comment #2

dawehner

German

CreditAttribution: dawehner commented 17 November 2010 at 21:15

Status:

Active

» Needs review

File	Size
974542-notice-pre_render.patch	5.46 KB

Does this patch fixes the problem for you?

Comment #3

phobia CreditAttribution: phobia commented 18 November 2010 at 14:10

Thanks for the patch, dereine. :)

It didn't fix my spesific problem which seems to be using the return of the field_view_field function directly in drupal_render.

Changing line 198 in modules/field/views_handler_field_field.inc to the following would solve it:

      $data = field_view_field($entity_type, $object, $this->definition['field_name'], $display);
      return drupal_render($data);

I could of course contribute this myself I guess, but I haven't read up on how to (all new to drupal ;), but I guess it's time. :)

Comment #4

dawehner

German

CreditAttribution: dawehner commented 18 November 2010 at 19:12

Feel free to create a new issue. Attach a patch and it will be commited.

Comment #5

bendiy CreditAttribution: bendiy commented 2 December 2010 at 20:14

@dereine
#2 fixed some issues I was having with Drupal Commerce.
#976106: Views errors before content is added

Comment #6

zOner CreditAttribution: zOner commented 3 December 2010 at 14:31

@dereine
the other fix is to remove the pass by reference in modules/field/views_handler_field_field.inc (rather than adding it everywhere else) as the function doesn't actually need to change the array, only sub-objects with it, i.e. change