Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When the user is logged in, the authorize div is empty.
Comment | File | Size | Author |
---|---|---|---|
#1 | page.tpl_.php_.patch | 1.59 KB | kimberlycoy |
Comments
Comment #1
kimberlycoy CreditAttribution: kimberlycoy commentedComment #2
danpros CreditAttribution: danpros commentedHi,
Yes the div is empty if user login and there is no rss feed on that page. Danland 6.x and 7.x is different since in D7 there is a toolbar at the top so I remove the login register links if user login.
I improve the layout with creating new individual wrapper for rss feed
I'll commit this changes soon. And I did some changes to css too
Removing and change this ine
Dan
Comment #3
cewolcott CreditAttribution: cewolcott commentedDan,
I am then confussed about the code. Just below the "authorize" div tag you are testing if the user is not logged in
<?php if (!$logged_in): ?>
, but then the next line you are testing if the $user->uid != 0 (thus logged in) and if so display "Logged in as .... | Logout" else display "Login | Register". But the "Logged in as .... " will never be displayed because of the initial test<?php if (!$logged_in): ?>
.Shouldn't you remove the
<?php if (!$logged_in): ?>
test so that a message is shown as to what account is logged in or if you need to Login?Chris
Comment #4
danpros CreditAttribution: danpros commentedHi Cris,
Yes I know that :) that is the 6.x code. Since the d7 already has a toolbar at the top I'll remove that link when login. Next release I'll change the code like this, very simple:
Dan
Comment #5
cewolcott CreditAttribution: cewolcott commentedDan,
When you say "The toolbar at the top" do you mean the Administration Toolbar (Black)? Which has Hello "username" and Log out on the right? That toolbar only shows up for users with administrative permissions. Normal users do not see the black toolbar, so please leave in the "Logged in as" and "Log out" items. You could test to see if the user has admin privs and remove it, but not a big deal.
Chris
Comment #6
danpros CreditAttribution: danpros commentedHi Chris,
Oh my.. I did not test to login as regular user :). Okay I'll leave that and change to this (maybe):
So if the user is admin than I'll remove that, how about that? I think that is the best solutions :)
Thanks for let me know about this.
Dan
Comment #7
cewolcott CreditAttribution: cewolcott commentedThat would be fine. You could also just leave it in since you will have feed icons showing on the same line and it would look a little empty without it. I have no problem showing the "Logged in as" when in admin mode. I wouldn't change the theme look just because drupal offers some wrapping around the outer edges of the theme.
Comment #8
danpros CreditAttribution: danpros commentedHi,
I already releasing the RC version that contains this fixes. I'll close this.
Thanks,
Dan
Comment #9
danpros CreditAttribution: danpros commentedChange it to proper category.