In Chrome (webkit?) browsers with the zen (starterkit?) themes the [Edit view] link is wrapped on two lines and not placed correctly, such that it obscures the first part of the first line of text of the view. This makes testing and development rather difficult, frustrating and annoying. This patch fixes the issue by making views' CSS more thorough, so that it is not easily (or accidentally) overridden by themes.
This bug may apply to other themes and/or browsers, but Chrome and starterkit are both very common combinations. This fix should catch a wide range of theme and browser issues that cause this.
I also re-ordered the related CSS selectors so that the CSS is more human-readable.
Comment | File | Size | Author |
---|---|---|---|
#3 | views-links-2.patch | 1.03 KB | dagmar |
#1 | Before.png | 12.43 KB | Bevan |
#1 | After.png | 12.42 KB | Bevan |
views-links.patch | 1.14 KB | Bevan | |
Comments
Comment #1
Bevan CreditAttribution: Bevan commentedThe attached screenshots show the bug before and after applying the patch. The [Edit view] link is black in the before screenshot because the "Digital" link can not be clicked and the [Edit view] link's hover state is triggered. In the after screenshot both the [Edit view] and the "Digital" link can be clicked.
Comment #2
dawehnerThis was quite annoying always.
Patch fixes the problem
@bevan
It saves some seconds if you can make a patch relative to the views root and not relative to your site-root and not using a/b
Comment #3
dagmarYes! finally a solution for this problem, thanks @bevan
@dereine here is a re-rolle using the views root path.
Comment #4
Bevan CreditAttribution: Bevan commenteddereine; Oops! My bad. I intended to, but slipped up.
Comment #5
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted to D6 branches. Doesn't apply to D7, should be a simple manual fix.
Comment #6
dawehnerI don't think this has to be ported.
Views uses contextual links which have their own css code.